Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .m.rule.contains_user_name push rule to highlight #2519

Merged
merged 2 commits into from May 1, 2020

Conversation

auscompgeek
Copy link
Contributor

@auscompgeek auscompgeek commented Apr 30, 2020

This fixes the default to match Synapse. anoa in #matrix-spec agreed that this is indeed a spec bug.

Signed-off-by: David Vo <david@vovo.id.au>
@turt2live
Copy link
Member

turt2live commented Apr 30, 2020

This needs a changelog, and also a description for why this is the correct fix for whatever the issue is.

Signed-off-by: David Vo <david@vovo.id.au>
Copy link
Member

@turt2live turt2live left a comment

Thanks!

@turt2live turt2live merged commit 0207242 into matrix-org:master May 1, 2020
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants