Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for new alias handling (client-server) #2562

Merged
merged 4 commits into from May 26, 2020

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented May 21, 2020

MSC: #2432

This commit does not deal with areas which will be covered by the room version specifications (namely the redaction algorithm).

It feels a bit overly cruel to completely obliterate all mentions of m.room.aliases from the spec as client/server developers may encounter the event type in the wild. To ensure that CTRL+F still works, a brief mention that they do nothing has been put in place, leaving no other references (except the redaction algorithm - see previous paragraph).

turt2live added 2 commits May 21, 2020
MSC: #2432

This commit does not deal with areas which will be covered by the room version specifications (namely the redaction algorithm).

It feels a bit overly cruel to completely obliterate all mentions of `m.room.aliases` from the spec as client/server developers may encounter the event type in the wild. To ensure that CTRL+F still works, a brief mention that they do nothing has been put in place, leaving no other references (except the redaction algorithm - see previous paragraph).
It's a bit awkward that this shows up as a backwards compatible change, but it's also not breaking.
@turt2live turt2live requested a review from May 21, 2020
@turt2live turt2live added next-release release-blocker labels May 25, 2020
api/client-server/directory.yaml Show resolved Hide resolved
api/client-server/directory.yaml Outdated Show resolved Hide resolved
specification/client_server_api.rst Outdated Show resolved Hide resolved
turt2live and others added 2 commits May 26, 2020
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
To avoid the conflict, hopefully.
@turt2live turt2live merged commit c328961 into master May 26, 2020
0 of 6 checks passed
@turt2live turt2live deleted the travis/spec/2432-alias-semantics branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release release-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants