MSC2702: Specifying semantics for Content-Disposition on media#2702
Merged
Conversation
turt2live
added
proposal-in-review
proposal
KitsuneRal
reviewed
Jul 29, 2020
KitsuneRal
approved these changes
Jul 29, 2020
Member
Author
|
Implementation: t2bot/matrix-media-repo@da0be74 |
turt2live
added
needs-implementation
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
davidegirardi
left a comment
davidegirardi
left a comment
There was a problem hiding this comment.
This review contains 3 comments but 2 of them are old ones. I will try to remove them after submitting this.
Member
Author
|
I think this is ready to go as a "nice to have" item for Matrix 1.9/the future: @mscbot fcp merge |
Collaborator
|
Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people: Concerns:
Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
mscbot
added
proposed-final-comment-period
dbkr
reviewed
Sep 12, 2023
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
richvdh
reviewed
Oct 3, 2023
richvdh
reviewed
Oct 3, 2023
Member
|
@mscbot concern outstanding discussion threads |
mscbot
added
the
unresolved-concerns
mscbot
added
the
final-comment-period
ara4n
reviewed
Jan 23, 2024
ara4n
reviewed
Jan 23, 2024
Collaborator
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
turt2live
added
spec-pr-missing
turt2live
added a commit
that referenced
this pull request
Jan 29, 2024
* Proposal to introduce sane Content-Disposition semantics * Update proposals/2702-media-content-disposition.md Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update for the year 2023 * Clarify thumbnails receiving Content-Disposition header * Clarify layering * Update proposals/2702-media-content-disposition.md Co-authored-by: David Baker <dbkr@users.noreply.github.com> * Fix wording * Apply suggestions from code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Clarify wording * Add clarifying words * Adjust security section --------- Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: David Baker <dbkr@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
23 tasks
6 tasks
Member
Author
|
Spec PR: matrix-org/matrix-spec#1758 |
41 tasks
Member
Author
|
Spec PR: matrix-org/matrix-spec#1935 |
turt2live
added
merged
Member
Author
|
Merged 🎉 |
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
t2bot/matrix-media-repo@da0be74- legacyFCP tickyboxes