Open
Conversation
turt2live
reviewed
Sep 11, 2020
| This proposal adds the following predefined rules to the default underride rules: | ||
| ``` | ||
| { | ||
| "rule_id": ".im.vector.jitsi", |
Member
There was a problem hiding this comment.
we shouldn't ever specify non-matrix namespaces
turt2live
added
kind:core
and use the existing ones as the unstable versions
Member
|
Hmm, this seems a weird direction given that push rules are on their way out: #2785 |
| @@ -0,0 +1,131 @@ | |||
| # MSC2772: Notifications for Jitsi Calls | |||
|
|
|||
| Matrix supports conference calls in rooms througth the use of Jitsi widgets. A user receives | |||
Member
There was a problem hiding this comment.
Suggested change
| Matrix supports conference calls in rooms througth the use of Jitsi widgets. A user receives | |
| Matrix supports conference calls in rooms through the use of Jitsi widgets. A user receives |
|
|
||
| Matrix supports conference calls in rooms througth the use of Jitsi widgets. A user receives | ||
| notifications when they receive a 1:1 VoIP call, but currently there are no notifications for | ||
| any widget being added to a room, including Jitsi widgets, so user are not notified when a |
Member
There was a problem hiding this comment.
Suggested change
| any widget being added to a room, including Jitsi widgets, so user are not notified when a | |
| any widget being added to a room, including Jitsi widgets, so users are not notified when a |
Comment on lines
+102
to
+103
| vs `m.jitsi` and `im.vector.modular.widgets` vs `m.widget`. Clients should provide present all three | ||
| of these rules as single rule to the user and apply the same mdifications to each one of these rule |
Member
There was a problem hiding this comment.
Suggested change
| vs `m.jitsi` and `im.vector.modular.widgets` vs `m.widget`. Clients should provide present all three | |
| of these rules as single rule to the user and apply the same mdifications to each one of these rule | |
| vs `m.jitsi` and `im.vector.modular.widgets` vs `m.widget`. Clients should present all three of these | |
| rules as a single rule to the user and apply the same modifications to each one of these rule |
| ## Security considerations | ||
|
|
||
| Implementors must ensure to implement the condition checking for a state event, else there would be | ||
| potential for this to be triggered by user without permission to send state events. |
Member
There was a problem hiding this comment.
Suggested change
| potential for this to be triggered by user without permission to send state events. | |
| potential for this to be triggered by users without permission to send state events. |
Member
|
The implementation of this MSC in Synapse has been merged: matrix-org/synapse#8286 |
turt2live
added
the
needs-implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a default push rule to trigger a notification when a Jitsi widget is added to a room.
Impl: matrix-org/synapse#8286
Rendered