Skip to content

MSC2867: Marking rooms as unread#2867

Merged
turt2live merged 7 commits into
matrix-org:old_masterfrom
Bubu:unread_rooms
Jun 24, 2024
Merged

MSC2867: Marking rooms as unread#2867
turt2live merged 7 commits into
matrix-org:old_masterfrom
Bubu:unread_rooms

Conversation

@Bubu
Copy link
Copy Markdown
Contributor

@Bubu Bubu commented Nov 17, 2020

@turt2live turt2live changed the title marking rooms as unread MSC2867: Marking rooms as unread Nov 17, 2020
@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal proposal-in-review labels Nov 17, 2020
@Bubu Bubu force-pushed the unread_rooms branch 2 times, most recently from c401fc2 to 8495e0b Compare November 17, 2020 21:51
Comment thread proposals/2867-rooms_marked_unread.md Outdated
Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
Comment thread proposals/2867-rooms_marked_unread.md
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 5, 2020
Using com.famedly.marked_unnread, as per [MSC2867](matrix-org/matrix-spec-proposals#2867)

TODO:
- Currently, when upgrading from an older version, already existing
  unread flags are ignored until cache is cleared manually

Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 5, 2020
Using com.famedly.marked_unnread, as per MSC2867
(matrix-org/matrix-spec-proposals#2867)

TODO:
- Currently, when upgrading from an older version, already existing
  unread flags are ignored until cache is cleared manually

Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 9, 2020
Using com.famedly.marked_unnread, as per MSC2867
(matrix-org/matrix-spec-proposals#2867)

TODO:
- Currently, when upgrading from an older version, already existing
  unread flags are ignored until cache is cleared manually

Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
@tulir
Copy link
Copy Markdown
Member

tulir commented Mar 19, 2021

This has been implemented in the Beeper app

Comment thread proposals/2867-rooms_marked_unread.md
@su-ex
Copy link
Copy Markdown

su-ex commented Nov 26, 2021

Next SchildiChat Web/Desktop release will have this too.

@dbkr
Copy link
Copy Markdown
Member

dbkr commented Feb 27, 2024

More implementations:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversely, this feature has been asked for for years and while simple, I think it covers the majority of use cases. I vote for getting this in to people's hands. In the future we can always migrate to something more powerful if that ends up being warranted.

aka. let's avoid letting perfect be the enemy of good and iterate instead of blocking further.

@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Jun 18, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jun 18, 2024
Comment thread proposals/2867-rooms_marked_unread.md Outdated
grammar improvement

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@mscbot
Copy link
Copy Markdown
Collaborator

mscbot commented Jun 23, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jun 23, 2024
@turt2live turt2live merged commit a0ef90e into matrix-org:old_master Jun 24, 2024
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jun 24, 2024
turt2live added a commit that referenced this pull request Jun 24, 2024
* marking rooms as unread

Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>

* Add alternative suggestion by @turt2live

Co-authored-by: Travis Ralston <travpc@gmail.com>

* mention that this msc lacks thread support

* typo fix

* clarify type of notification we are referring to

* fix some small typos

* Update proposals/2867-rooms_marked_unread.md

grammar improvement

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

---------

Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Johennes added a commit to Johennes/matrix-spec that referenced this pull request Jul 1, 2024
Relates to: matrix-org/matrix-spec-proposals#2867
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@tulir
Copy link
Copy Markdown
Member

tulir commented Jul 9, 2024

Spec PR: matrix-org/matrix-spec#1895

@tulir tulir added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jul 9, 2024
@clokep clokep added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jul 15, 2024
@turt2live
Copy link
Copy Markdown
Member

Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Projects

Status: Merged/Done

Development

Successfully merging this pull request may close these issues.