Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2943: Return an event ID for membership endpoints #2943

Open
wants to merge 1 commit into
base: old_master
Choose a base branch
from
Open

MSC2943: Return an event ID for membership endpoints #2943

wants to merge 1 commit into from

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jan 7, 2021 •
edited
Loading

@turt2live turt2live changed the title Return an event ID for membership endpoints MSC2943: Return an event ID for membership endpoints Jan 7, 2021
@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review client-server Client-Server API labels Jan 7, 2021
richvdh
richvdh approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me. I don't really know why these endpoints didn't return an event id in the first place.

uhoreg
uhoreg approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. I think an argument could be made that the unstable prefix is not needed since it is a field that already exists on other endpoints and follows the same semantics as those endpoints.

@turt2live
Copy link
Member Author

I'm not convinced that this needs a specific implementation on its own: if people disagree, please concern it.

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jun 8, 2021 •
edited
Loading

This FCP proposal has been cancelled by #2943 (comment).

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • can haz impl plz

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Jun 8, 2021
@richvdh
Copy link
Member

richvdh commented Jun 8, 2021

I think I'd like to see an impl. I wouldn't mind betting we'll find a reason it's not as simple as it sounds for at least one of those endpoints.

@richvdh
Copy link
Member

richvdh commented Jun 15, 2021

@mscbot concern can haz impl plz

@mscbot mscbot added the unresolved-concerns This proposal has at least one outstanding concern label Jun 15, 2021
@richvdh richvdh added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 15, 2021
@turt2live
Copy link
Member Author

If this is blocked on implementation then my past suggestion to concern it was wrong. It should have been to do this:

@mscbot fcp cancel

@mscbot mscbot added proposal-in-review and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Apr 8, 2022
@turt2live turt2live self-assigned this Jul 19, 2022
@turt2live turt2live mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg approved these changes

@richvdh richvdh richvdh approved these changes

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees

@turt2live turt2live

Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal unresolved-concerns This proposal has at least one outstanding concern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider returning an event ID for /invite
5 participants
@turt2live @mscbot @richvdh @uhoreg @KitsuneRal