MSC3086: Asserted identity on VoIP calls#3086
Open
dbkr wants to merge 4 commits into
Open
Conversation
dbkr
changed the title
dbkr
added
kind:feature
kevincox
approved these changes
Apr 2, 2021
| @@ -0,0 +1,104 @@ | |||
| # MSC3086: Asserted Identity for VoIP Calls | |||
Contributor
There was a problem hiding this comment.
This is a nit but "Asserted" sounds too strong to me. Before I opened the doc I would think that it had been asserted via strong cryptography or similar, and there is a chance that someone seeing the events might think the same. Would something like "Proxied Identity", "Delegated Identity" or even "Suggested Identity" make more sens? I see that in the SIP case this talks about authenticated identities making the call (although I guess in that case the authentication isn't e2e).
Co-authored-by: Kevin Cox <kevincox@kevincox.ca>
dbkr
changed the title
turt2live
added
the
needs-implementation
| "call_id": "thE1dofth1scallisthis5trIng", | ||
| "party_id": "abcdef", | ||
| "asserted_identity": { | ||
| "id": "@alice:rabbithole.example", |
Contributor
There was a problem hiding this comment.
I think using user_id here to be more explicit could be a bit better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered