Sprinkle some DANGER: UNSAFE warnings over the spec about event bodies #3099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporates #3025
ara4n
reviewed
Apr 6, 2021
ara4n
reviewed
Apr 6, 2021
ara4n
approved these changes
Apr 6, 2021
Member
ara4n
left a comment
ara4n
left a comment
There was a problem hiding this comment.
lgtm, modulo clarifying that it's computers which need to verify event bodies, not humans.
Co-authored-by: Matthew Hodgson <matthew@matrix.org>
Member
Author
|
fair point, thanks for catching |
richvdh
pushed a commit
that referenced
this pull request
Aug 23, 2021
…d-bodies Sprinkle some DANGER: UNSAFE warnings over the spec about event bodies
richvdh
pushed a commit
that referenced
this pull request
Aug 27, 2021
…d-bodies Sprinkle some DANGER: UNSAFE warnings over the spec about event bodies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs MSC2801
Based on #3094
See pull/3094/head...pull/3099/head for the real diff.