Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3306: Counting unread messages #3306

Closed
wants to merge 2 commits into from

Conversation

KitsuneRal
Copy link
Member

@KitsuneRal KitsuneRal commented Aug 2, 2021

Rendered

See #2654 instead.

@KitsuneRal KitsuneRal changed the title MSCXXXX: Counting unread messages MSC3306: Counting unread messages Aug 2, 2021
@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal proposal-in-review push labels Aug 2, 2021
Comment on lines +29 to +33
with `action` set to `notify`. There's merit therefore providing a common
"notable events" criterion, both for homeservers to calculate the unread count
uniformly but also for clients so that they could provide more accurate numbers
when it's possible and/or even customise the calculation algorithm to
users' liking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we rather be fixing the pushrules to match the reality returned by homeservers? Hardcoding a room count algorithm sounds bad. I have specific keyword mentions set on rooms, etc. I expect the notification count to reflect that, not some arbitrary, homeserver specific algorithm. Can you describe in which way the count currently calculated by homeservers and your algorithm differ from what would be calculated by following the push rules?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or am I confused and you meant unread counts (not notification counts), which have an algorithm specified here: #2654 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did mean an unread count - however, as the MSC mentions, Synapse returns it under the name of notification_count, which is quite confusing since the number of notifications is different. And yes, I should have searched for prior art... Closing this, and will contribute to #2654 instead.

@KitsuneRal KitsuneRal added obsolete A proposal which has been overtaken by other proposals and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal-in-review labels Aug 3, 2021
@KitsuneRal KitsuneRal closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec obsolete A proposal which has been overtaken by other proposals proposal A matrix spec change proposal push
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants