Rename threepidCreds to threepid_creds and get rid of array #3471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the behaviour to match what synapse implements in practice. If you use threepidCreds, you will just get an error about a missing threepid_creds field. Synapse also treats this as an object. All clients also seem to send threepid_creds, if they work on Synapse. Since matrix.org requires an email currently for registration, most clients that implement registration, will hit this issue. https://github.com/matrix-org/synapse/blob/a0f48ee89d88fd7b6da8023dbba607a69073152e/synapse/handlers/ui_auth/checkers.py#L145 fixes matrix-org#3156 fixes matrix-org#2189 Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
deepbluev7
added a commit
to Nheko-Reborn/nheko
that referenced
this pull request
Nov 3, 2021
This was a bit of a journey: matrix-org/matrix-spec-proposals#3471 But it should work now and we now use the UIAHandler everywhere. fixes #670
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
|
I couldn't find anything about this in the openapi spec, so I am assuming there are no changes needed there. |
|
(sorry ruma and fluffy, but this is the right decision for the reasons set out at #2189 (comment)) |
|
Ruma seems to be happy to fix this, from when I talked to them. Fluffy I'll fix myself, so this is fine, I think. ;-) |
huangred
pushed a commit
to huangred/matrix_api_lite
that referenced
this pull request
Jan 10, 2022
For context, see matrix-org/matrix-spec-proposals#3471 Basically the spec was wrong and didn't match what clients and servers were doing. Might fix registration on matrix.org. BREAKING CHANGE: Any client that implements the email portion will fail to build now.
td-famedly
pushed a commit
to famedly/dart_matrix_api_lite
that referenced
this pull request
Mar 22, 2024
For context, see matrix-org/matrix-spec-proposals#3471 Basically the spec was wrong and didn't match what clients and servers were doing. Might fix registration on matrix.org. BREAKING CHANGE: Any client that implements the email portion will fail to build now.
td-famedly
pushed a commit
to famedly/dart_matrix_api_lite
that referenced
this pull request
Mar 22, 2024
For context, see matrix-org/matrix-spec-proposals#3471 Basically the spec was wrong and didn't match what clients and servers were doing. Might fix registration on matrix.org. BREAKING CHANGE: Any client that implements the email portion will fail to build now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour to match what synapse implements in practice.
If you use threepidCreds, you will just get an error about a missing
threepid_creds field. Synapse also treats this as an object. All clients
also seem to send threepid_creds, if they work on Synapse. Since
matrix.org requires an email currently for registration, most clients
that implement registration, will hit this issue.
https://github.com/matrix-org/synapse/blob/a0f48ee89d88fd7b6da8023dbba607a69073152e/synapse/handlers/ui_auth/checkers.py#L145
fixes #3156
fixes #2189
Signed-off-by: Nicolas Werner nicolas.werner@hotmail.de
Note that there is a lot of debate about this in the different issues. I really don't care about how this is resolved, but after 4 years, can please someone either fix this in synapse or matrix-doc? I just wasted half a day on this, the 3pid stuff in UIA is complicated enough. Alternatively I can add a note in the spec, that this is still up for debate and clients should send multiple versions of the auth dict, until one of them works or something, that at least suggests, that the spec does not match reality.
Current reality is that clients use an object called
threepid_creds, Synapse uses it. It is probably easier to change the spec at this point. But I haven't checked what other servers do, I am still doing that.(fluffy actually seems to send both spelling variations as an array... Ruma added that variant now...)
(Nheko doesn't care, I'll implement whatever we decide on, but I just fixed it to work on Synapse today.)
(Couldn't find anything in libQuotient)
Preview: https://pr3471--matrix-org-previews.netlify.app