Skip to content

Explicitly link to geo URI spec #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Explicitly link to geo URI spec #3492

merged 3 commits into from
Nov 15, 2021

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Nov 15, 2021

We mention geo uri in the spec, but unhelpfully do not link to any documentation on what those are. This PR explicitly names the RFC and links to it. I am unsure if this needs a MSC, since I believe it doesn't change the spec in a meaningful way and just clarifies which RFC we're talking about.

If this needs a proposal, happy to open one first.

Preview: https://pr3492--matrix-org-previews.netlify.app

@anoadragon453
Copy link
Member

Seeing as that RFC looks to be what the spec was originally referring to (and matches the example event body), then this is just a clarification - and as such does not need an MSC.

@anoadragon453 anoadragon453 requested a review from a team November 15, 2021 11:28
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm. Please add a changelog entry :)

Half-Shot and others added 2 commits November 15, 2021 22:49
Co-authored-by: Travis Ralston <travisr@matrix.org>
@Half-Shot Half-Shot requested a review from turt2live November 15, 2021 22:51
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@turt2live turt2live merged commit 51d8560 into main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants