MSC3551: Extensible Events - Files #3551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
changed the title
turt2live
added
kind:core
This was referenced Dec 7, 2021
tulir
reviewed
Jan 19, 2022
| "hashes": { | ||
| "sha256": "fdSLu/YkRx3Wyh3KQabP3rd6+SFiKg5lsJZQHtkSAYA" | ||
| }, | ||
| "v": "v2" |
There was a problem hiding this comment.
The v field name is a bit weird here, since it's specific to the encryption stuff. Might be nicer to have something like encrypted_version and then use the presence and value of that field to determine if the file is encrypted (and if it's supported) rather than using the presence of key. Alternatively, the encryption parts could be nested in an another object.
There was a problem hiding this comment.
another object sounds appealing tbh: m.encrypted for all the encrypted things.
will consider the alternatives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Blocked by #1767
Preview: https://pr3551--matrix-org-previews.netlify.app