-
Notifications
You must be signed in to change notification settings - Fork 397
Clarify that base_url
in client well_known
may or may not include trailing slash
#3562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine - can we get a changelog please? :)
So I didn't help,I made something work or not??? Humm
…On Wed, Dec 8, 2021, 8:25 PM Travis Ralston ***@***.***> wrote:
***@***.**** commented on this pull request.
Overall looks fine - can we get a changelog please? :)
------------------------------
In content/client-server-api/_index.md
<#3562 (comment)>
:
> + 2. It is important to note that this value may or may not include
+ a trailing `/`. Consumers should be prepared to handle both
+ cases.
We've found that "may" introduces more confusion than not in the formal
spec:
⬇️ Suggested change
- 2. It is important to note that this value may or may not include
- a trailing `/`. Consumers should be prepared to handle both
- cases.
+ 2. It is important to note that this value might not include
+ a trailing `/`. Consumers should be prepared to handle both
+ cases.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3562 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMXLIEVRZTUUYTBH7SZ3H63UQAHSFANCNFSM5JU2GDLA>
.
|
Sorry @shenanigans77-jpg, I'm not sure what you mean? |
content/client-server-api/_index.md
Outdated
2. It is important to note that this value might include a trailing | ||
`/`. Consumers should be prepared to handle both cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to move this a bit further down - it doesn't seem to make much sense to talk about trailing slashes before validating it as a URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you!
Fixes #3465. The change adds a line explicitly warning developers that the
base_url
of clientwell_known
may or may not include a trailing slash and to be prepared to handle both cases.Preview: https://pr3562--matrix-org-previews.netlify.app