Repository navigation
MSC3780: Knocking on action=join - #3780
Open
ShadowJonathan wants to merge 3 commits into
Open
ShadowJonathan wants to merge 3 commits into
ShadowJonathan wants to merge 3 commits into
Conversation
ShadowJonathan
changed the title
action=joinaction=join
Mikaela
approved these changes
Apr 20, 2022
Mikaela
left a comment
Mikaela
left a comment
Contributor
There was a problem hiding this comment.
This is an issue I care about, I don't know if it's common policy to hardcode specific spec versions to proposals.
Mikaela
approved these changes
Apr 20, 2022
uhoreg
added
proposal-in-review
proposal
KitsuneRal
reviewed
May 3, 2022
| failing to join) that a room is only knockable. | ||
|
|
||
| [MSC3266] - Room Summaries - maybe be | ||
| required to allow the client to easily and deterministically infer if a room is (only) knockable. |
Member
Contributor
There was a problem hiding this comment.
Nheko now implements a prettier variant using MSC3266 (but has a fallback if a room is not previewable still): Nheko-Reborn/nheko@9d8d6b4
Mikaela
reviewed
May 24, 2022
Mikaela
added a commit
to Mikaela/mikaela.github.io
that referenced
this pull request
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Resolves matrix-org/matrix-spec#1015
Implementations;
Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>