Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3780: Knocking on action=join #3780

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ShadowJonathan
Copy link
Contributor

@ShadowJonathan ShadowJonathan commented Apr 20, 2022

Rendered

Resolves matrix-org/matrix-spec#1015

Implementations;

  • JS SDK (#TDB)
  • Nheko (source)

Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>

@ShadowJonathan ShadowJonathan changed the title MSCXXXX: Knocking on action=join MSC3780: Knocking on action=join Apr 20, 2022
Copy link
Contributor

@Mikaela Mikaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an issue I care about, I don't know if it's common policy to hardcode specific spec versions to proposals.

proposals/3780-action-join-knock.md Outdated Show resolved Hide resolved
proposals/3780-action-join-knock.md Show resolved Hide resolved
proposals/3780-action-join-knock.md Outdated Show resolved Hide resolved
proposals/3780-action-join-knock.md Show resolved Hide resolved
@uhoreg uhoreg added proposal-in-review proposal A matrix spec change proposal kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Apr 25, 2022
failing to join) that a room is only knockable.

[MSC3266] - Room Summaries - maybe be
required to allow the client to easily and deterministically infer if a room is (only) knockable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach but without MSC3266, the UX for that becomes rather problematic; so it might be prudent to land this MSC after MSC3266 (mainly a note to SCT).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nheko now implements a prettier variant using MSC3266 (but has a fallback if a room is not previewable still): Nheko-Reborn/nheko@9d8d6b4

Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

Mikaela added a commit to Mikaela/mikaela.github.io that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Matrix URI scheme actions to include action=knock
7 participants