Draft
Conversation
4 tasks
ara4n
reviewed
May 13, 2022
|
|
||
| ```json | ||
| { | ||
| "type": "m.world", |
Member
There was a problem hiding this comment.
what's the state key? presumably we should be able to support multiple GLBs per world in order to represent the compose hierarchy?
Contributor
Author
There was a problem hiding this comment.
I'd imagine glTF composition will likely happen within the glTF itself. This allows us to reference and parent glTF scenes to nodes, override properties, and more. That'll be dependent on a glTF spec proposal. I think that's more desirable than just trying to merge multiple glTFs into one scene and allows us to hopefully eventually specify this within the correct standards body.
Member
There was a problem hiding this comment.
kk. if you compose like that, will the GLTFs (or GLB) binary diff nicely against each other?
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft spec for specifying Third Room's 3D environments and avatars. It may very well end up in a vendor specification. The spec is still under heavy development and not ready for review.
Rendered