Skip to content

MSC3827: Filtering of /publicRooms by room type#3827

Merged
anoadragon453 merged 9 commits into
mainfrom
SimonBrandner/msc/space-explore
Jul 25, 2022
Merged

MSC3827: Filtering of /publicRooms by room type#3827
anoadragon453 merged 9 commits into
mainfrom
SimonBrandner/msc/space-explore

Conversation

@SimonBrandner

@SimonBrandner SimonBrandner commented May 27, 2022 •
edited by clokep
Loading

Copy link
Copy Markdown
Contributor

@SimonBrandner SimonBrandner force-pushed the SimonBrandner/msc/space-explore branch 2 times, most recently from 8626833 to 8e17922 Compare May 27, 2022 14:03
@SimonBrandner SimonBrandner changed the title MSC0000: Filtering of /publicRooms by room type MSC3827: Filtering of /publicRooms by room type May 27, 2022
@SimonBrandner SimonBrandner force-pushed the SimonBrandner/msc/space-explore branch 2 times, most recently from d262908 to 1d6acfc Compare May 27, 2022 14:06
@SimonBrandner
Write Filtering of /publicRooms by room type
1d6acfc 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner added A-Client Server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal. Process state. needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels May 27, 2022
@SimonBrandner SimonBrandner marked this pull request as ready for review May 27, 2022 14:08
clokep
clokep reviewed May 27, 2022
View reviewed changes
Comment thread proposals/3827-space-explore.md Outdated
ShadowJonathan
ShadowJonathan reviewed May 27, 2022
View reviewed changes
Comment thread proposals/3827-space-explore.md Outdated
clokep
clokep reviewed May 27, 2022
View reviewed changes
Comment thread proposals/3827-space-explore.md Outdated
@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec and removed kind:feature MSC for not-core and not-maintenance stuff labels May 27, 2022
@SimonBrandner @ShadowJonathan
Improve wording to be more clear
4140ec3 
Co-authored-by: Jonathan de Jong <jonathandejong02@gmail.com>
@clokep clokep mentioned this pull request May 27, 2022
Closed
3 tasks
This was referenced Jun 12, 2022
Merged
Closed
Merged
@SimonBrandner
Specify handling of edge cases
ae782b1 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner requested a review from clokep June 18, 2022 09:11
@SimonBrandner
Use plural
748b258 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner mentioned this pull request Jun 18, 2022
Merged
@SimonBrandner
Don't change the defautl behaviour
f5ca17f 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
turt2live approved these changes Jun 29, 2022
View reviewed changes

@turt2live turt2live left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible as an approach given directory-as-a-space is a long way's out.

@turt2live

turt2live commented Jun 29, 2022

Copy link
Copy Markdown
Member

I'm also comfortable with the level of implementation here:

@mscbot fcp merge

@mscbot

mscbot commented Jun 29, 2022 •
edited by ara4n
Loading

Copy link
Copy Markdown
Collaborator

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 29, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/msc/space-explore branch July 25, 2022 10:41
@anoadragon453 anoadragon453 added spec-pr-missing MSC is accepted, but missing spec PR. Process state. and removed finished-final-comment-period FCP has finished. Process state. labels Jul 25, 2022
@SimonBrandner SimonBrandner mentioned this pull request Jul 25, 2022
Merged
@turt2live turt2live self-assigned this Aug 2, 2022
@turt2live turt2live mentioned this pull request Aug 3, 2022
Merged
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 3, 2022
@turt2live
Add room_types and room_type to /publicRooms
7c833d5 
MSC: matrix-org/matrix-spec-proposals#3827
Incorporates matrix-org/matrix-spec-proposals#3858
@turt2live turt2live mentioned this pull request Aug 3, 2022
Merged
@turt2live

turt2live commented Aug 3, 2022

Copy link
Copy Markdown
Member

Spec PR: matrix-org/matrix-spec#1199

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels Aug 3, 2022
@zecakeh zecakeh mentioned this pull request Aug 3, 2022
Merged
turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 4, 2022
@turt2live
Add room_types and room_type to /publicRooms (#1199)
b14759a 
MSC: matrix-org/matrix-spec-proposals#3827
Incorporates matrix-org/matrix-spec-proposals#3858
@turt2live

turt2live commented Aug 4, 2022

Copy link
Copy Markdown
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Aug 4, 2022
@SimonBrandner SimonBrandner mentioned this pull request Aug 24, 2022
Closed
Fizzadar added a commit to beeper/synapse-legacy-fork that referenced this pull request Aug 25, 2022
@Fizzadar
Merge tag 'v1.65.0' into beeper
84eef5b 
Synapse 1.65.0 (2022-08-16)
===========================

No significant changes since 1.65.0rc2.

Synapse 1.65.0rc2 (2022-08-11)
==============================

Internal Changes
----------------

- Revert 'Remove the unspecced `room_id` field in the `/hierarchy` response. ([\matrix-org#13365](matrix-org#13365))' to give more time for clients to update. ([\matrix-org#13501](matrix-org#13501))

Synapse 1.65.0rc1 (2022-08-09)
==============================

Features
--------

- Add support for stable prefixes for [MSC2285 (private read receipts)](matrix-org/matrix-spec-proposals#2285). ([\matrix-org#13273](matrix-org#13273))
- Add new unstable error codes `ORG.MATRIX.MSC3848.ALREADY_JOINED`, `ORG.MATRIX.MSC3848.NOT_JOINED`, and `ORG.MATRIX.MSC3848.INSUFFICIENT_POWER` described in [MSC3848](matrix-org/matrix-spec-proposals#3848). ([\matrix-org#13343](matrix-org#13343))
- Use stable prefixes for [MSC3827](matrix-org/matrix-spec-proposals#3827). ([\matrix-org#13370](matrix-org#13370))
- Add a new module API method to translate a room alias into a room ID. ([\matrix-org#13428](matrix-org#13428))
- Add a new module API method to create a room. ([\matrix-org#13429](matrix-org#13429))
- Add remote join capability to the module API's `update_room_membership` method (in a backwards compatible manner). ([\matrix-org#13441](matrix-org#13441))

Bugfixes
--------

- Update the version of the LDAP3 auth provider module included in the `matrixdotorg/synapse` DockerHub images and the Debian packages hosted on packages.matrix.org to 0.2.2. This version fixes a regression in the module. ([\matrix-org#13470](matrix-org#13470))
- Fix a bug introduced in Synapse v1.41.0 where the `/hierarchy` API returned non-standard information (a `room_id` field under each entry in `children_state`). ([\matrix-org#13365](matrix-org#13365))
- Fix a bug introduced in Synapse 0.24.0 that would respond with the wrong error status code to `/joined_members` requests when the requester is not a current member of the room. Contributed by @andrewdoh. ([\matrix-org#13374](matrix-org#13374))
- Fix bug in handling of typing events for appservices. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#13392](matrix-org#13392))
- Fix a bug introduced in Synapse 1.57.0 where rooms listed in `exclude_rooms_from_sync` in the configuration file would not be properly excluded from incremental syncs. ([\matrix-org#13408](matrix-org#13408))
- Fix a bug in the experimental faster-room-joins support which could cause it to get stuck in an infinite loop. ([\matrix-org#13353](matrix-org#13353))
- Faster room joins: fix a bug which caused rejected events to become un-rejected during state syncing. ([\matrix-org#13413](matrix-org#13413))
- Faster room joins: fix error when running out of servers to sync partial state with, so that Synapse raises the intended error instead. ([\matrix-org#13432](matrix-org#13432))

Updates to the Docker image
---------------------------

- Make Docker images build on armv7 by installing cryptography dependencies in the 'requirements' stage. Contributed by Jasper Spaans. ([\matrix-org#13372](matrix-org#13372))

Improved Documentation
----------------------

- Update the 'registration tokens' page to acknowledge that the relevant MSC was merged into version 1.2 of the Matrix specification. Contributed by @moan0s. ([\matrix-org#11897](matrix-org#11897))
- Document which HTTP resources support gzip compression. ([\matrix-org#13221](matrix-org#13221))
- Add steps describing how to elevate an existing user to administrator by manipulating the database. ([\matrix-org#13230](matrix-org#13230))
- Fix wrong headline for `url_preview_accept_language` in documentation. ([\matrix-org#13437](matrix-org#13437))
- Remove redundant 'Contents' section from the Configuration Manual. Contributed by @dklimpel. ([\matrix-org#13438](matrix-org#13438))
- Update documentation for config setting `macaroon_secret_key`. ([\matrix-org#13443](matrix-org#13443))
- Update outdated information on `sso_mapping_providers` documentation. ([\matrix-org#13449](matrix-org#13449))
- Fix example code in module documentation of `password_auth_provider_callbacks`. ([\matrix-org#13450](matrix-org#13450))
- Make the configuration for the cache clearer. ([\matrix-org#13481](matrix-org#13481))

Internal Changes
----------------

- Extend the release script to automatically push a new SyTest branch, rather than having that be a manual process. ([\matrix-org#12978](matrix-org#12978))
- Make minor clarifications to the error messages given when we fail to join a room via any server. ([\matrix-org#13160](matrix-org#13160))
- Enable Complement CI tests in the 'latest deps' test run. ([\matrix-org#13213](matrix-org#13213))
- Fix long-standing bugged logic which was never hit in `get_pdu` asking every remote destination even after it finds an event. ([\matrix-org#13346](matrix-org#13346))
- Faster room joins: avoid blocking when pulling events with partially missing prev events. ([\matrix-org#13355](matrix-org#13355))
- Instrument `/messages` for understandable traces in Jaeger. ([\matrix-org#13368](matrix-org#13368))
- Remove an unused argument to `get_relations_for_event`. ([\matrix-org#13383](matrix-org#13383))
- Add a `merge-back` command to the release script, which automates merging the correct branches after a release. ([\matrix-org#13393](matrix-org#13393))
- Adding missing type hints to tests. ([\matrix-org#13397](matrix-org#13397))
- Faster Room Joins: don't leave a stuck room partial state flag if the join fails. ([\matrix-org#13403](matrix-org#13403))
- Refactor `_resolve_state_at_missing_prevs` to compute an `EventContext` instead. ([\matrix-org#13404](matrix-org#13404), [\matrix-org#13431](matrix-org#13431))
- Faster Room Joins: prevent Synapse from answering federated join requests for a room which it has not fully joined yet. ([\matrix-org#13416](matrix-org#13416))
- Re-enable running Complement tests against Synapse with workers. ([\matrix-org#13420](matrix-org#13420))
- Prevent unnecessary lookups to any external `get_event` cache. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#13435](matrix-org#13435))
- Add some tracing to give more insight into local room joins. ([\matrix-org#13439](matrix-org#13439))
- Rename class `RateLimitConfig` to `RatelimitSettings` and `FederationRateLimitConfig` to `FederationRatelimitSettings`. ([\matrix-org#13442](matrix-org#13442))
- Add some comments about how event push actions are stored. ([\matrix-org#13445](matrix-org#13445), [\matrix-org#13455](matrix-org#13455))
- Improve rebuild speed for the "synapse-workers" docker image. ([\matrix-org#13447](matrix-org#13447))
- Fix `@tag_args` being off-by-one with the arguments when tagging a span (tracing). ([\matrix-org#13452](matrix-org#13452))
- Update type of `EventContext.rejected`. ([\matrix-org#13460](matrix-org#13460))
- Use literals in place of `HTTPStatus` constants in tests. ([\matrix-org#13463](matrix-org#13463), [\matrix-org#13469](matrix-org#13469))
- Correct a misnamed argument in state res v2 internals. ([\matrix-org#13467](matrix-org#13467))
@zecakeh zecakeh mentioned this pull request Sep 4, 2022
Closed
54 tasks
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 4, 2022
chat/matrix-synapse: Update to 1.65.0
d34f293 
packaging changes:

summary of upstream changes:

Synapse 1.65.0 (2022-08-16)
===========================

Features
--------

- Add support for stable prefixes for [MSC2285 (private read receipts)](matrix-org/matrix-spec-proposals#2285). ([\#13273](matrix-org/synapse#13273))

- Add new unstable error codes `ORG.MATRIX.MSC3848.ALREADY_JOINED`,
  `ORG.MATRIX.MSC3848.NOT_JOINED`, and
  `ORG.MATRIX.MSC3848.INSUFFICIENT_POWER` described in
  [MSC3848](matrix-org/matrix-spec-proposals#3848).
  ([\#13343](matrix-org/synapse#13343))

- Use stable prefixes for
  [MSC3827](matrix-org/matrix-spec-proposals#3827).
  ([\#13370](matrix-org/synapse#13370))

- Add a new module API method to translate a room alias into a room
  ID. ([\#13428](matrix-org/synapse#13428))

- Add a new module API method to create a
  room. ([\#13429](matrix-org/synapse#13429))

- Add remote join capability to the module API's
  `update_room_membership` method (in a backwards compatible
  manner). ([\#13441](matrix-org/synapse#13441))
ghost
ghost reviewed Sep 22, 2022
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ch

benkuly added a commit to connect2x-de/trixnity that referenced this pull request Nov 2, 2022
@benkuly
Add room_types filter and room_type response to /publicRooms, a…
98b3dd5 
…s per [MSC3827](matrix-org/matrix-spec-proposals#3827)
jevolk added a commit to jevolk/charybdis that referenced this pull request Apr 22, 2023
@jevolk
ircd::m::rooms: Implement matrix-org/matrix-spec-proposals#3827
238cc10
@julioromano julioromano mentioned this pull request Sep 29, 2023
Closed
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
14 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
14 tasks
@deepbluev7 deepbluev7 mentioned this pull request Jan 10, 2025
Merged
msk pushed a commit to msk/pkgsrc that referenced this pull request May 11, 2026
chat/matrix-synapse: Update to 1.65.0
3d961a9 
packaging changes:

summary of upstream changes:

Synapse 1.65.0 (2022-08-16)
===========================

Features
--------

- Add support for stable prefixes for [MSC2285 (private read receipts)](matrix-org/matrix-spec-proposals#2285). ([\#13273](matrix-org/synapse#13273))

- Add new unstable error codes `ORG.MATRIX.MSC3848.ALREADY_JOINED`,
  `ORG.MATRIX.MSC3848.NOT_JOINED`, and
  `ORG.MATRIX.MSC3848.INSUFFICIENT_POWER` described in
  [MSC3848](matrix-org/matrix-spec-proposals#3848).
  ([\#13343](matrix-org/synapse#13343))

- Use stable prefixes for
  [MSC3827](matrix-org/matrix-spec-proposals#3827).
  ([\#13370](matrix-org/synapse#13370))

- Add a new module API method to translate a room alias into a room
  ID. ([\#13428](matrix-org/synapse#13428))

- Add a new module API method to create a
  room. ([\#13429](matrix-org/synapse#13429))

- Add remote join capability to the module API's
  `update_room_membership` method (in a backwards compatible
  manner). ([\#13441](matrix-org/synapse#13441))
jperkin pushed a commit to TritonDataCenter/pkgsrc that referenced this pull request May 14, 2026
chat/matrix-synapse: Update to 1.65.0
4150aa3 
packaging changes:

summary of upstream changes:

Synapse 1.65.0 (2022-08-16)
===========================

Features
--------

- Add support for stable prefixes for [MSC2285 (private read receipts)](matrix-org/matrix-spec-proposals#2285). ([\#13273](matrix-org/synapse#13273))

- Add new unstable error codes `ORG.MATRIX.MSC3848.ALREADY_JOINED`,
  `ORG.MATRIX.MSC3848.NOT_JOINED`, and
  `ORG.MATRIX.MSC3848.INSUFFICIENT_POWER` described in
  [MSC3848](matrix-org/matrix-spec-proposals#3848).
  ([\#13343](matrix-org/synapse#13343))

- Use stable prefixes for
  [MSC3827](matrix-org/matrix-spec-proposals#3827).
  ([\#13370](matrix-org/synapse#13370))

- Add a new module API method to translate a room alias into a room
  ID. ([\#13428](matrix-org/synapse#13428))

- Add a new module API method to create a
  room. ([\#13429](matrix-org/synapse#13429))

- Add remote join capability to the module API's
  `update_room_membership` method (in a backwards compatible
  manner). ([\#13441](matrix-org/synapse#13441))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uhoreg uhoreg uhoreg left review comments
@clokep clokep clokep approved these changes
@turt2live turt2live turt2live approved these changes
@anoadragon453 anoadragon453 anoadragon453 approved these changes
@richvdh richvdh richvdh approved these changes
+3 more reviewers
@ShadowJonathan ShadowJonathan ShadowJonathan left review comments
@hillbilly3281 hillbilly3281 hillbilly3281 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@turt2live turt2live

Labels

A-Client Server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! Process state. proposal A matrix spec change proposal. Process state.

Projects

Spec Core Team Workflow
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a UI to explore public spaces

10 participants

@SimonBrandner @turt2live @mscbot @ara4n @clokep @uhoreg @anoadragon453 @richvdh @ShadowJonathan @hillbilly3281