MSC3828: Content Repository CORP Headers#3828
Merged
anoadragon453 merged 9 commits intoJul 25, 2022
Merged
Conversation
robertlong
changed the title
Co-authored-by: Nate Martin <nate.teh.greatt@gmail.com>
uhoreg
reviewed
Jun 1, 2022
uhoreg
added
proposal
ara4n
removed
the
needs-implementation
turt2live
approved these changes
Jun 4, 2022
turt2live
left a comment
turt2live
left a comment
Member
There was a problem hiding this comment.
once housekeeping is done I think this is ready for FCP.
robertlong
commented
Jun 9, 2022
turt2live
reviewed
Jun 14, 2022
turt2live
approved these changes
Jun 14, 2022
Member
|
@mscbot fcp merge |
Collaborator
|
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
mscbot
added
disposition-merge
Co-authored-by: Travis Ralston <travpc@gmail.com>
richvdh
approved these changes
Jul 19, 2022
anoadragon453
approved these changes
Jul 19, 2022
anoadragon453
left a comment
anoadragon453
left a comment
Member
There was a problem hiding this comment.
Seems to align with the definitions for the following headers from MDN:
And looks to be successfully implemented and running on thirdroom.io.
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
Collaborator
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
anoadragon453
added
spec-pr-missing
turt2live
added a commit
to matrix-org/matrix-spec
that referenced
this pull request
Aug 2, 2022
turt2live
added a commit
to matrix-org/matrix-spec
that referenced
this pull request
Aug 2, 2022
Member
|
spec PR: matrix-org/matrix-spec#1197 |
turt2live
added
spec-pr-in-review
turt2live
added a commit
to matrix-org/matrix-spec
that referenced
this pull request
Aug 9, 2022
* Add CORP headers to media repo MSC: matrix-org/matrix-spec-proposals#3828 * Write weird CSS rules to make added-in work inline in the CS spec Even though our content doesn't need 2 paragraphs, it's good to have the capability to render it in the future. * Remove test paragraph * Refine prose * spelling is key
Member
|
Merged 🎉 |
turt2live
added
merged
54 tasks
14 tasks
S7evinK
added a commit
to matrix-org/dendrite
that referenced
this pull request
Jan 10, 2024
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synapse PR: matrix-org/synapse#12944
Rendered
FCP Checkboxes