MSC3846: Allowing widgets to access TURN servers#3846
Open
robintown wants to merge 5 commits intomatrix-org:mainfrom
Open
MSC3846: Allowing widgets to access TURN servers#3846robintown wants to merge 5 commits intomatrix-org:mainfrom
robintown wants to merge 5 commits intomatrix-org:mainfrom
Conversation
turt2live
reviewed
Jul 13, 2022
dbkr
approved these changes
Jul 14, 2022
Member
dbkr
left a comment
There was a problem hiding this comment.
Looks good from my PoV - subscription model is a nice way of doing it and avoids the widget & the client having different ideas on when they want fresh credentials.
This was referenced Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations