Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MSC3864: User-given attributes for rooms #3864

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Zocker1999NET
Copy link

@Zocker1999NET Zocker1999NET commented Aug 7, 2022

Signed-off-by: Felix Stupp felix.stupp+github@banananet.work

@Zocker1999NET Zocker1999NET changed the title MSCXXXX: User-given nicknames & descriptions for rooms & users MSC3864: User-given nicknames & descriptions for rooms & users Aug 7, 2022
@Zocker1999NET Zocker1999NET force-pushed the room-nicknames branch 2 times, most recently from af872af to 5c36dbc Compare August 7, 2022 15:03
@Zocker1999NET Zocker1999NET changed the title MSC3864: User-given nicknames & descriptions for rooms & users [WIP] MSC3864: User-given nicknames & descriptions for rooms & users Aug 7, 2022
@Zocker1999NET Zocker1999NET marked this pull request as draft August 7, 2022 20:32
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Aug 8, 2022
@turt2live
Copy link
Member

@Zocker1999NET when you get the chance, please Sign Off on your changes.

Zocker1999NET added a commit to Zocker1999NET/matrix-spec-proposals that referenced this pull request Aug 9, 2022
user's user-given attributes now defined in
[MSC3865](matrix-org#3865)
@Zocker1999NET Zocker1999NET changed the title [WIP] MSC3864: User-given nicknames & descriptions for rooms & users [WIP] MSC3864: User-given attributes for rooms Aug 9, 2022
@Zocker1999NET
Copy link
Author

I've found another proposal #3015 which may overlap with this one. I will check how both overlap and if, looking at the feature set and way of implementation, one is superior to the other. If so, they may should be merged.

@Mart-Bogdan
Copy link

@Zocker1999NET I think that other proposal is abandoned. So if you would like to continue it would be great.

I agree with comments from discussion on other MSC, abut naming. Perhaps move user_given to the end. Or we can just leave it as is: m.user_given.user.displayname .

What do you think? I guess we need to resume discussion in room you've created: #mscs-3015-3864-3865:matrix.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants