MSC3874: Filtering threads from the /messages endpoint by justjanne · Pull Request #3874 · matrix-org/matrix-spec-proposals

justjanne · 2022-08-23T11:10:12Z

Rendered

Implementations:

Synapse: Support filtering the /messages API by relation type (MSC3874) synapse#14148

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

germain-gg

Great job for a first draft of an MSC!! Minor things to update, but this looks really good to me as a starting point

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

turt2live · 2022-09-05T17:55:54Z

This is actively undergoing implementation and needs sanity review to ensure it's on a good track. It is worth noting that this MSC is likely to accelerate quickly into FCP, so review which is more in line with that would be appreciated.

turt2live

Generally this seems sane to me - looking forward to implementation :)

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

clokep

Looks good and seems to match the synapse implementation!

Upstream changes: Synapse 1.70.1 (2022-10-28) =========================== (bugfixes) Synapse 1.70.0 (2022-10-26) =========================== Features -------- - Support for [MSC3856](matrix-org/matrix-spec-proposals#3856): threads list API. ([\#13394](matrix-org/synapse#13394), [\#14171](matrix-org/synapse#14171), [\#14175](matrix-org/synapse#14175)) - Support for thread-specific notifications & receipts ([MSC3771](matrix-org/matrix-spec-proposals#3771) and [MSC3773](matrix-org/matrix-spec-proposals#3773)). ([\#13776](matrix-org/synapse#13776), [\#13824](matrix-org/synapse#13824), [\#13877](matrix-org/synapse#13877), [\#13878](matrix-org/synapse#13878), [\#14050](matrix-org/synapse#14050), [\#14140](matrix-org/synapse#14140), [\#14159](matrix-org/synapse#14159), [\#14163](matrix-org/synapse#14163), [\#14174](matrix-org/synapse#14174), [\#14222](matrix-org/synapse#14222)) - Stop fetching missing `prev_events` after we already know their signature is invalid. ([\#13816](matrix-org/synapse#13816)) - Send application service access tokens as a header (and query parameter). Implements [MSC2832](matrix-org/matrix-spec-proposals#2832). ([\#13996](matrix-org/synapse#13996)) - Ignore server ACL changes when generating pushes. Implements [MSC3786](matrix-org/matrix-spec-proposals#3786). ([\#13997](matrix-org/synapse#13997)) - Experimental support for redirecting to an implementation of a [MSC3886](matrix-org/matrix-spec-proposals#3886) HTTP rendezvous service. ([\#14018](matrix-org/synapse#14018)) - The `/relations` endpoint can now be used on workers. ([\#14028](matrix-org/synapse#14028)) - Advertise support for Matrix 1.3 and 1.4 on `/_matrix/client/versions`. ([\#14032](matrix-org/synapse#14032), [\#14184](matrix-org/synapse#14184)) - Improve validation of request bodies for the [Device Management](https://spec.matrix.org/v1.4/client-server-api/#device-management) and [MSC2697 Device Dehyrdation](matrix-org/matrix-spec-proposals#2697) client-server API endpoints. ([\#14054](matrix-org/synapse#14054)) - Experimental support for [MSC3874](matrix-org/matrix-spec-proposals#3874): Filtering threads from the `/messages` endpoint. ([\#14148](matrix-org/synapse#14148)) - Improve the validation of the following PUT endpoints: [`/directory/room/{roomAlias}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directoryroomroomalias), [`/directory/list/room/{roomId}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directorylistroomroomid) and [`/directory/list/appservice/{networkId}/{roomId}`](https://spec.matrix.org/v1.4/application-service-api/#put_matrixclientv3directorylistappservicenetworkidroomid). ([\#14179](matrix-org/synapse#14179)) Deprecations and Removals ------------------------- - Remove the experimental implementation of [MSC3772](matrix-org/matrix-spec-proposals#3772). ([\#14094](matrix-org/synapse#14094)) - Remove the unstable identifier for [MSC3715](matrix-org/matrix-spec-proposals#3715). ([\#14106](matrix-org/synapse#14106), [\#14146](matrix-org/synapse#14146))

@ashfame

Synapse 1.72.0 (2022-11-22) =========================== Please note that Synapse now only supports PostgreSQL 11+, because PostgreSQL 10 has reached end-of-life, c.f. our [Deprecation Policy](https://github.com/matrix-org/synapse/blob/develop/docs/deprecation_policy.md). Bugfixes -------- - Update forgotten references to legacy metrics in the included Grafana dashboard. ([\matrix-org#14477](matrix-org#14477)) Synapse 1.72.0rc1 (2022-11-16) ============================== Features -------- - Add experimental support for [MSC3912](matrix-org/matrix-spec-proposals#3912): Relation-based redactions. ([\matrix-org#14260](matrix-org#14260)) - Build Debian packages for Ubuntu 22.10 (Kinetic Kudu). ([\matrix-org#14396](matrix-org#14396)) - Add an [Admin API](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html) endpoint for user lookup based on third-party ID (3PID). Contributed by @ashfame. ([\matrix-org#14405](matrix-org#14405)) - Faster joins: include heroes' membership events in the partial join response, for rooms without a name or canonical alias. ([\matrix-org#14442](matrix-org#14442)) Bugfixes -------- - Faster joins: do not block creation of or queries for room aliases during the resync. ([\matrix-org#14292](matrix-org#14292)) - Fix a bug introduced in Synapse 1.64.0rc1 which could cause log spam when fetching events from other homeservers. ([\matrix-org#14347](matrix-org#14347)) - Fix a bug introduced in 1.66 which would not send certain pushrules to clients. Contributed by Nico. ([\matrix-org#14356](matrix-org#14356)) - Fix a bug introduced in v1.71.0rc1 where the power level event was incorrectly created during initial room creation. ([\matrix-org#14361](matrix-org#14361)) - Fix the refresh token endpoint to be under /r0 and /v3 instead of /v1. Contributed by Tulir @ Beeper. ([\matrix-org#14364](matrix-org#14364)) - Fix a long-standing bug where Synapse would raise an error when encountering an unrecognised field in a `/sync` filter, instead of ignoring it for forward compatibility. ([\matrix-org#14369](matrix-org#14369)) - Fix a background database update, introduced in Synapse 1.64.0, which could cause poor database performance. ([\matrix-org#14374](matrix-org#14374)) - Fix PostgreSQL sometimes using table scans for queries against the `event_search` table, taking a long time and a large amount of IO. ([\matrix-org#14409](matrix-org#14409)) - Fix rendering of some HTML templates (including emails). Introduced in v1.71.0. ([\matrix-org#14448](matrix-org#14448)) - Fix a bug introduced in Synapse 1.70.0 where the background updates to add non-thread unique indexes on receipts could fail when upgrading from 1.67.0 or earlier. ([\matrix-org#14453](matrix-org#14453)) Updates to the Docker image --------------------------- - Add all Stream Writer worker types to `configure_workers_and_start.py`. ([\matrix-org#14197](matrix-org#14197)) - Remove references to legacy worker types in the multi-worker Dockerfile. ([\matrix-org#14294](matrix-org#14294)) Improved Documentation ---------------------- - Upload documentation PRs to Netlify. ([\matrix-org#12947](matrix-org#12947), [\matrix-org#14370](matrix-org#14370)) - Add addtional TURN server configuration example based on [eturnal](https://github.com/processone/eturnal) and adjust general TURN server doc structure. ([\matrix-org#14293](matrix-org#14293)) - Add example on how to load balance /sync requests. Contributed by [aceArt](https://aceart.de). ([\matrix-org#14297](matrix-org#14297)) - Edit sample Nginx reverse proxy configuration to use HTTP/1.1. Contributed by Brad Jones. ([\matrix-org#14414](matrix-org#14414)) Deprecations and Removals ------------------------- - Remove support for PostgreSQL 10. ([\matrix-org#14392](matrix-org#14392), [\matrix-org#14397](matrix-org#14397)) Internal Changes ---------------- - Run unit tests against Python 3.11. ([\matrix-org#13812](matrix-org#13812)) - Add TLS support for generic worker endpoints. ([\matrix-org#14128](matrix-org#14128), [\matrix-org#14455](matrix-org#14455)) - Switch to a maintained action for installing Rust in CI. ([\matrix-org#14313](matrix-org#14313)) - Add override ability to `complement.sh` command line script to request certain types of workers. ([\matrix-org#14324](matrix-org#14324)) - Enabling testing of [MSC3874](matrix-org/matrix-spec-proposals#3874) (filtering of `/messages` by relation type) in complement. ([\matrix-org#14339](matrix-org#14339)) - Concisely log a failure to resolve state due to missing `prev_events`. ([\matrix-org#14346](matrix-org#14346)) - Use a maintained Github action to install Rust. ([\matrix-org#14351](matrix-org#14351)) - Cleanup old worker datastore classes. Contributed by Nick @ Beeper (@Fizzadar). ([\matrix-org#14375](matrix-org#14375)) - Test against PostgreSQL 15 in CI. ([\matrix-org#14394](matrix-org#14394)) - Remove unreachable code. ([\matrix-org#14410](matrix-org#14410)) - Clean-up event persistence code. ([\matrix-org#14411](matrix-org#14411)) - Update docstring to clarify that `get_partial_state_events_batch` does not just give you completely arbitrary partial-state events. ([\matrix-org#14417](matrix-org#14417)) - Fix mypy errors introduced by bumping the locked version of `attrs` and `gitpython`. ([\matrix-org#14433](matrix-org#14433)) - Make Dependabot only bump Rust deps in the lock file. ([\matrix-org#14434](matrix-org#14434)) - Fix an incorrect stub return type for `PushRuleEvaluator.run`. ([\matrix-org#14451](matrix-org#14451)) - Improve performance of `/context` in large rooms. ([\matrix-org#14461](matrix-org#14461))

justjanne force-pushed the justjanne/messages-endpoint-threads-filter branch from 8e59026 to 898b47e Compare August 23, 2022 11:10

justjanne added proposal A matrix spec change proposal kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Aug 23, 2022

justjanne force-pushed the justjanne/messages-endpoint-threads-filter branch from 898b47e to 77da34f Compare August 23, 2022 11:12

MSC3874: Filtering threads from the /messages endpoint

5afe6c3

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

justjanne force-pushed the justjanne/messages-endpoint-threads-filter branch from 77da34f to 5afe6c3 Compare August 23, 2022 12:34

germain-gg reviewed Aug 23, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

germain-gg reviewed Aug 23, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

germain-gg reviewed Aug 23, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

turt2live added kind:core MSC which is critical to the protocol's success client-server Client-Server API and removed kind:feature MSC for not-core and not-maintenance stuff labels Aug 23, 2022

justjanne added 4 commits August 24, 2022 13:57

Avoid accidental double spaces

04ece96

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Rephrase and clarify motivation

0061a08

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Correct specified endpoint

5ef2e9e

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Clarify and describe limitations

6fa06d8

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

clokep reviewed Aug 24, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

clokep reviewed Aug 24, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

clokep reviewed Aug 24, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

clokep reviewed Aug 24, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

clokep reviewed Aug 24, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

justjanne added 5 commits August 25, 2022 14:42

Improve formatting

86c88b4

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Mark already merged PRs

ceff9c9

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Use production URL again

df54176

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Correct issue where rel_types and related_by_rel_types got mixed up

6fff095

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Add mobile reasoning to motivation

9476b7f

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

justjanne requested review from clokep and germain-gg August 25, 2022 14:37

clokep reviewed Aug 25, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

justjanne added 2 commits August 26, 2022 11:33

Clarify example

e28ba77

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

Correct proposal wording

b14510f

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

germain-gg reviewed Aug 28, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

germain-gg mentioned this pull request Aug 31, 2022

Threads are missing from the threads list element-hq/element-web#21911

Closed

justjanne marked this pull request as ready for review September 5, 2022 08:53

turt2live approved these changes Sep 6, 2022

View reviewed changes

turt2live mentioned this pull request Sep 10, 2022

MSC3030: Jump to date API endpoint #3030

Merged

MadLittleMods mentioned this pull request Sep 14, 2022

Ask to refresh timeline when historical messages are imported (MSC2716) matrix-org/matrix-react-sdk#8354

Closed

3 tasks

justjanne self-assigned this Oct 17, 2022

Address comments on proposal

747daf1

Signed-off-by: Janne Mareike Koschinski <jannemk@element.io>

justjanne requested review from clokep, germain-gg and turt2live October 18, 2022 12:36

clokep reviewed Oct 18, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

clokep reviewed Oct 18, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

clokep reviewed Oct 18, 2022

View reviewed changes

Comment thread proposals/3874-messages-endpoint-threads-filter.md Outdated

Apply suggestions from code review

8d607ca

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

clokep approved these changes Oct 19, 2022

View reviewed changes

germain-gg mentioned this pull request Oct 20, 2022

After jump to unread, timeline is out of order and showing a thread message in the main timeline element-hq/element-web#21922

Open

germain-gg removed their request for review December 9, 2022 10:46

jdauphant mentioned this pull request Apr 3, 2023

En tant qu'utilisateur, je souhaite répondre dans un fils de discussion afin d'avoir une meilleure gestion des discussions tchapgouv/tchap-web-v4#522

Open

turt2live removed their request for review June 6, 2023 19:49

t3chguy mentioned this pull request Jun 19, 2023

Always clear unread status in room and send read receipt when using "Mark as read" feature element-hq/element-web#25611

Closed

t3chguy mentioned this pull request Jul 31, 2023

Element stops asking for history if it's full of reactions element-hq/element-web#25873

Open

Conversation

justjanne commented Aug 23, 2022 • edited by clokep Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

germain-gg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

turt2live commented Sep 5, 2022

Uh oh!

turt2live left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clokep left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

justjanne commented Aug 23, 2022 •

edited by clokep

Loading