MSC4001: Return start of room state at context endpoint#4001
Open
BramvdnHeuvel wants to merge 3 commits into
Open
MSC4001: Return start of room state at context endpoint#4001BramvdnHeuvel wants to merge 3 commits into
BramvdnHeuvel wants to merge 3 commits into
Conversation
BramvdnHeuvel
changed the title
BramvdnHeuvel
changed the title
BramvdnHeuvel
marked this pull request as ready for review
April 21, 2023 15:58
uhoreg
added
proposal
uhoreg
reviewed
Apr 21, 2023
uhoreg
reviewed
Apr 21, 2023
|
|
||
| ## Proposal | ||
|
|
||
| For the same reason that this behaviour was altered for the `GET /_matrix/client/v3/sync` endpoint, the endpoint `GET /_matrix/client/v3/rooms/{roomId}/context/{eventId}` should use the `state` field in its 200 response to return the room state at the **first** event returned. |
Member
There was a problem hiding this comment.
Under the assumption that this isn't a spec bug, this would be be an incompatible change and could break clients that rely on the current behaviour. This could be solved by adding a query parameter to indicate that the server should use this behaviour. Alternatively, the version number on this endpoint could be bumped. Or you could show that clients don't rely on the current behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.