Skip to content

Conversation

@tulir
Copy link
Member

@tulir tulir commented Jul 19, 2024

Signed-off-by: Tulir Asokan <tulir@maunium.net>
@tulir tulir added proposal A matrix spec change proposal client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff labels Jul 19, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there was already a doc for this, probably should've looked for that before writing it myself 🙈 https://github.com/element-hq/element-meta/blob/develop/spec/functional_members.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just add this as a link somewhere in the MSC?

@Half-Shot Half-Shot self-requested a review July 23, 2024 13:52
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely I think the text is fine, I just had a few quibbles.

solve the issue eventually, but implementing those will likely take quite a
while due to the complexity of the system. This proposal is an intermediate
solution for bots before canonical DMs are fully implemented.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of note is that this has been in use in Element since July 2021, so it's fairly well battle tested at this point.

tulir added 6 commits July 30, 2024 11:48
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
Signed-off-by: Tulir Asokan <tulir@maunium.net>
service members from `m.heroes` on the server side, but that may also cause
other issues.

## Alternatives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also #4015 I think?

@@ -0,0 +1,69 @@
# MSC4171: Service members
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B. Element implements this in their "auditbot" integration, although the code is closed source.

Signed-off-by: Tulir Asokan <tulir@maunium.net>
poljar added a commit to matrix-org/matrix-rust-sdk that referenced this pull request Dec 5, 2024
Introduce support for MSC4171, enabling the designation of certain users
as service members. These flagged users are excluded from the room
display name calculation.

MSC: matrix-org/matrix-spec-proposals#4171
poljar added a commit to matrix-org/matrix-rust-sdk that referenced this pull request Dec 5, 2024
Introduce support for MSC4171, enabling the designation of certain users
as service members. These flagged users are excluded from the room
display name calculation.

MSC: matrix-org/matrix-spec-proposals#4171
poljar added a commit to matrix-org/matrix-rust-sdk that referenced this pull request Dec 12, 2024
This state event allows us to correctly calculate the room display name
according to MSC4171.

MSC: matrix-org/matrix-spec-proposals#4171
poljar added a commit to matrix-org/matrix-rust-sdk that referenced this pull request Dec 12, 2024
This state event allows us to correctly calculate the room display name
according to MSC4171.

MSC: matrix-org/matrix-spec-proposals#4171
poljar added a commit to matrix-org/matrix-rust-sdk that referenced this pull request Dec 12, 2024
This state event allows us to correctly calculate the room display name
according to MSC4171.

MSC: matrix-org/matrix-spec-proposals#4171
andybalaam pushed a commit to matrix-org/matrix-rust-sdk that referenced this pull request Dec 18, 2024
Introduce support for MSC4171, enabling the designation of certain users
as service members. These flagged users are excluded from the room
display name calculation.

MSC: matrix-org/matrix-spec-proposals#4171
andybalaam pushed a commit to matrix-org/matrix-rust-sdk that referenced this pull request Dec 18, 2024
This state event allows us to correctly calculate the room display name
according to MSC4171.

MSC: matrix-org/matrix-spec-proposals#4171
yostyle pushed a commit to tchapgouv/matrix-rust-sdk that referenced this pull request Apr 4, 2025
Introduce support for MSC4171, enabling the designation of certain users
as service members. These flagged users are excluded from the room
display name calculation.

MSC: matrix-org/matrix-spec-proposals#4171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants