Open
Conversation
turt2live
changed the title
turt2live
added
push
proposal
Johennes
reviewed
Aug 30, 2024
Comment on lines
+41
to
+43
| Clients SHOULD NOT execute push rules locally on events with `m.push_rules_executed: false` as this | ||
| may cause notification counts to desynchronize from the server, leading to 'stuck notifications' for | ||
| the user. |
Contributor
There was a problem hiding this comment.
Clients that don't support this proposal yet, won't act on push_rules_executed if a server implements and enables this proposal. Therefore, these clients might run higher risk of hitting 'stuck notifications' which might be worth calling out in the potential issues section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
In line with matrix-org/matrix-spec#1700, the following disclosure applies:
I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published as a Trust & Safety team member allocated in full to the Foundation.