Skip to content

MSC4191: Account management for OAuth 2.0 API #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
turt2live merged 12 commits into from
Nov 24, 2025
Merged

MSC4191: Account management for OAuth 2.0 API #4191

turt2live merged 12 commits into from
Nov 24, 2025

Conversation

@sandhose
Copy link
Member

@sandhose sandhose commented Sep 12, 2024 •
edited by turt2live
Loading

Rendered

Implementions:

To do:

  • Update references to MSC3861 as it has been accepted
  • Add clarification about being the replacement for delete devices API endpoints when using OAuth 2.0 API
  • Check for consistency with MSC3824

In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am a Software Engineer at Element. This proposal was written and published as an Element employee.

SCT Stuff:

FCP tickyboxes

MSC checklist

@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 12, 2024
@sandhose sandhose mentioned this pull request Sep 16, 2024
Merged
@Thatoo Thatoo mentioned this pull request Nov 8, 2024
Closed
@zecakeh zecakeh mentioned this pull request Jan 28, 2025
Merged
@TheOneWithTheBraid TheOneWithTheBraid mentioned this pull request Feb 7, 2025
Open
14 tasks
t3chguy
t3chguy reviewed Mar 18, 2025
View reviewed changes
@zecakeh zecakeh mentioned this pull request May 24, 2025
Merged
3 tasks
@hughns hughns mentioned this pull request Sep 15, 2025
Merged
11 tasks
@hughns hughns marked this pull request as ready for review September 17, 2025 17:04
@hughns hughns changed the title MSC4191: Account management deep-linking MSC4191: Account management deep-linking for OAuth 2.0 API Sep 17, 2025
@github-project-automation github-project-automation bot moved this to Tracking for review in Spec Core Team Workflow Sep 17, 2025
@turt2live turt2live added the matrix-2.0 Required for Matrix 2.0 label Sep 17, 2025
@turt2live turt2live moved this from Tracking for review to Proposed for FCP readiness in Spec Core Team Workflow Sep 17, 2025
@Johennes Johennes mentioned this pull request Sep 18, 2025
Merged
4 tasks
@hughns hughns changed the title MSC4191: Account management deep-linking for OAuth 2.0 API MSC4191: Account management for OAuth 2.0 API Sep 23, 2025
hughns
hughns reviewed Sep 23, 2025
View reviewed changes
@turt2live
Copy link
Member

turt2live commented Sep 24, 2025

@mscbot fcp merge
@mscbot concern Pending preliminary approval from oauth-ext-review to use the new names - https://mailarchive.ietf.org/arch/msg/oauth-ext-review/6RQXusbqFTy-XZCGwLSW-RIa9Dg/

@mscbot
Copy link
Collaborator

mscbot commented Sep 24, 2025 •
edited
Loading

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge unresolved-concerns This proposal has at least one outstanding concern labels Sep 24, 2025
richvdh
richvdh reviewed Sep 30, 2025
View reviewed changes
@hughns @richvdh
Update proposals/4191-account-deeplink.md
d9bdee2 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@Johennes Johennes mentioned this pull request Oct 17, 2025
Merged
3 tasks
Johennes
Johennes reviewed Oct 17, 2025
View reviewed changes
hughns and others added 2 commits October 20, 2025 10:56
@hughns @Johennes
Update proposals/4191-account-deeplink.md
46b463e 
Co-authored-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@hughns
Update cross-signing reset action with additional details
2b12d0d 
Added a reference to MSC4312 for cross-signing reset details.
tonkku107
tonkku107 suggested changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@tonkku107 tonkku107 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.matrix.session_end was renamed to org.matrix.device_delete but the rest of the proposal didn't follow

@hughns @tonkku107
Apply suggestions from code review
ea6f4a9 
Co-authored-by: Tonkku <contact@tonkku.me>
@turt2live
Copy link
Member

turt2live commented Nov 18, 2025

Per recent emails sent to oauth-ext-review on our thread, it seems possible to allow this MSC to go through without formal registration. When we get to the spec PR, we should verbosely describe the fields so we can point to them in a more complete registration application.

@mscbot resolve Pending preliminary approval from oauth-ext-review to use the new names - https://mailarchive.ietf.org/arch/msg/oauth-ext-review/6RQXusbqFTy-XZCGwLSW-RIa9Dg/

@mscbot
Copy link
Collaborator

mscbot commented Nov 18, 2025

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. unresolved-concerns This proposal has at least one outstanding concern labels Nov 18, 2025
@turt2live turt2live removed the 00-weekly-pings Tracking for weekly pings in the SCT office. 00 to make it first in the labels list. label Nov 18, 2025
@turt2live turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Workflow Nov 18, 2025
@mscbot
Copy link
Collaborator

mscbot commented Nov 23, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Nov 23, 2025
@turt2live turt2live merged commit 2b6da16 into main Nov 24, 2025
1 check passed
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Nov 24, 2025
@turt2live turt2live moved this from In FCP to Requires spec writing in Spec Core Team Workflow Nov 24, 2025
@zecakeh
Copy link
Contributor

zecakeh commented Dec 16, 2025

Spec PR: matrix-org/matrix-spec#2270

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Dec 16, 2025
@turt2live turt2live moved this from Requires spec writing to Requires spec PR review in Spec Core Team Workflow Dec 16, 2025
@hughns hughns mentioned this pull request Jan 7, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clokep clokep clokep left review comments

@uhoreg uhoreg uhoreg left review comments

@richvdh richvdh richvdh left review comments

@t3chguy t3chguy t3chguy left review comments

@hughns hughns hughns left review comments

+2 more reviewers

@Johennes Johennes Johennes left review comments

@tonkku107 tonkku107 tonkku107 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

client-server Client-Server API kind:core MSC which is critical to the protocol's success matrix-2.0 Required for Matrix 2.0 proposal A matrix spec change proposal spec-pr-in-review A proposal which has been PR'd against the spec and is in review

Projects

Spec Core Team Workflow
Status: Requires spec PR review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.