Skip to content

Conversation

@tonkku107
Copy link
Contributor

@tonkku107 tonkku107 commented Sep 24, 2024

Rendered

Implementations:

@tonkku107 tonkku107 changed the title MSC0000: Usage of OIDC login_hint MSC4198: Usage of OIDC login_hint Sep 24, 2024
@tonkku107 tonkku107 marked this pull request as ready for review September 24, 2024 13:06
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 25, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • Client
  • Authentication service (I think?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authentication service

well... technically just "server"? nobody is prescribing the auth to happen in an extra microservice, right?

Copy link

@noelportillo noelportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First thing that came out

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

  • Updating to reflect that OAuth 2.0 API now exists in the spec
  • Making it explicit that this is an optional parameter for the Authorization code grant
  • Propose that that the login_hint can also be added to the MSC4191 account management URL query parameters (perhaps prefixed as org.matrix.msc4198.login_hint)

By using RFC2119 keywords and reiterating that the parameter is optional in the usage section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants