MSC4234: Update app badge counts when rooms are read#4234
Open
ara4n wants to merge 4 commits into
Open
Conversation
ara4n
added
proposal
clokep
reviewed
Dec 2, 2024
Comment on lines
+37
to
+38
| e2ee_badge_aware clients to set `cleared_notifs: true` on every RR they send if they spot that the user has per-device | ||
| rules. Alternatively, they could set `cleared_notifs: true` whatever when the user reads the most recent message in |
Member
There was a problem hiding this comment.
per-device push rules don't exist? Do you mean if there are e.g. a push rule that one client hasn't yet implemented?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Written with my SCT member hat on.
Split out of MSC4076