Arrange a few titles #1126
Merged
Arrange a few titles #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, PublicRoomsChunk in the spec text could be found in two places (actually three but the third one is identical to the first one), defining two (_mostly_ identical but) different schemas. Ctrl-F'ing through the spec may confuse you with the "wrong" definition. This commit gives distinct schemas distinct names; aside from PublicRoomChunk, the same story happens with the derivative of stripped_state.yaml used in space_hierarchy.yaml (it's not exactly StrippedStateEvent either). As for the removal of `PublicRoomsChunks` (plural) - this title is unnecessary because the tooling would place rather self-explanatory `[PublicRoomsChunk]` without it, whereas the plural title ends up with no definition in the spec text.
turt2live
approved these changes
Jun 15, 2022
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, PublicRoomsChunk in the spec text could be found in two places (actually three but this one is identical to the first one), defining two (mostly identical but) different
schemas. Ctrl-F'ing through the spec may confuse you with the "wrong" definition. This commit gives distinct schemas distinct names; aside from PublicRoomChunk, the same story happens with the derivative of stripped_state.yaml used in space_hierarchy.yaml (it's not exactly StrippedStateEvent either).
As for the removal of
PublicRoomsChunks(plural) - this title is unnecessary because the tooling would place rather self-explanatory[PublicRoomsChunk]without it, whereas the plural title ends up with no definition in the spec text.Signed-off-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
Preview: https://pr1126--matrix-spec-previews.netlify.app