Skip to content

Add room_types and room_type to /publicRooms#1199

Merged
turt2live merged 1 commit intomainfrom
travis/filter-spaces
Aug 4, 2022
Merged

Add room_types and room_type to /publicRooms#1199
turt2live merged 1 commit intomainfrom
travis/filter-spaces

Conversation

@turt2live
Copy link
Member

@turt2live turt2live commented Aug 3, 2022

@turt2live turt2live marked this pull request as ready for review August 3, 2022 00:26
@turt2live turt2live requested a review from a team as a code owner August 3, 2022 00:26
Copy link

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@@ -0,0 +1 @@
Add `room_types` filter and `room_type` response to `/publicRooms`, as per [MSC3827](https://github.com/matrix-org/matrix-spec-proposals/pull/3827). No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a newline here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog system doesn't really care, so it depends on whether my editor decided to add it or not :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants