Skip to content

Clarify room version grammar #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Clarify room version grammar #1422

merged 1 commit into from
Jan 31, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 31, 2023

It is not legal to use characters outside a-z, 0-9, ., and -.

Fixes #1408

Preview: https://pr1422--matrix-spec-previews.netlify.app

Apparently the SHOULD is confusing
@richvdh richvdh requested a review from a team as a code owner January 31, 2023 18:51
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #1408 (comment) for rationale.

tldr is this would normally require an MSC to change, but given the history of this issue that feels overly silly.

@richvdh richvdh merged commit a7790fc into main Jan 31, 2023
@richvdh richvdh deleted the rav/fix_room_version_grammar branch January 31, 2023 20:00
clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023
Apparently the SHOULD is confusing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room version grammar is inconsistent
2 participants