Reduce whitespace on mobile viewports #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
johannes/mobile-spacing
branch
from
0077dc2 to
5cd141c
Compare
richvdh
requested changes
Mar 26, 2024
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
Thanks for this! A few suggestions.
richvdh
reviewed
Mar 26, 2024
| .pageinfo-primary { | ||
| max-width: 80%; | ||
| @media (min-width: 768px) { | ||
| max-width: 80%; |
Member
There was a problem hiding this comment.
No action required, but #761 is related here. The whole thing is a mess.
Contributor
Author
There was a problem hiding this comment.
Oh, interesting. Yeah, I had noticed some of the other content having odd widths, too, but tried to keep changes to a minimum here.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm probably the only person occasionally reading the spec on my phone but whenever I do it's usually quite cumbersome. One of the issues is a sub-optimal use of white space. This PR removes some of the needless emptiness on mobile viewports.
Preview: https://pr1770--matrix-spec-previews.netlify.app