Deprecate authentication via a query string#1808
Merged
richvdh merged 2 commits intomatrix-org:mainfrom Apr 30, 2024
Merged
Conversation
As per MSC4126 Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
53 tasks
Johennes
reviewed
Jun 10, 2024
Contributor
There was a problem hiding this comment.
@zecakeh should this be a .deprecation as per the list in https://github.com/matrix-org/matrix-spec/blob/main/CONTRIBUTING.rst#adding-to-the-changelog?
Member
There was a problem hiding this comment.
(we'll fix it during the changelog cleanup at release time - if there's other notable issues, please mention them in #sct-office:matrix.org)
Contributor
There was a problem hiding this comment.
Ok, yeah sorry for commenting on a closed PR. I wasn't sure what the proper process was. Would it help at all if I sent a PR renaming the file?
Member
There was a problem hiding this comment.
Unfortunately not, as that PR then requires a changelog itself. Our release process has a "normalize the changelog" step which takes care of this for us.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per MSC4126.
It seems that OpenAPI 3.1 doesn't allow to mark a security scheme as deprecated, which is why I put it in the description.
Preview: https://pr1808--matrix-spec-previews.netlify.app