e2ee/qr: clarify that the device's Ed25519 signing key should be used #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source @uhoreg in #e2e:matrix.org: https://matrix.to/#/matrix.org/$J6UbQwsakEsHMbv5yH7RUpM-OlklZ4U3Ti3VqWp9p8E?via=matrix.org&via=privacytools.io&via=envs.net > It should be the ed25519 key. There was probably a bit of a > terminology mixup in the MSC. But all verification methods verify the > ed25519 key. In theory, devices should be able to change their > curve25519 key, as long as the ed25519 key stays the same, though I > don't think anyone has ever actually tried that, and I don't know what > would happen if someone did. (I suspect that we would see lots of > exciting errors) Signed-off-by: Sumner Evans <sumner.evans@automattic.com>
sumnerevans
force-pushed
the
clarify-qr-code-format
branch
from
8c58177 to
da21b19
Compare
Member
|
For the record: the affected bit of spec is https://spec.matrix.org/v1.10/client-server-api/#qr-code-format. |
richvdh
reviewed
May 28, 2024
richvdh
approved these changes
May 28, 2024
Member
richvdh
left a comment
richvdh
left a comment
There was a problem hiding this comment.
lgtm other than consistency nit in the changelog. Thanks!
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source @uhoreg in #e2e:matrix.org:
https://matrix.to/#/matrix.org/$J6UbQwsakEsHMbv5yH7RUpM-OlklZ4U3Ti3VqWp9p8E?via=matrix.org&via=privacytools.io&via=envs.net
Signed-off-by: Sumner Evans sumner.evans@automattic.com
Pull Request Checklist
Preview: https://pr1829--matrix-spec-previews.netlify.app