Move size limits for user, room and event IDs into the appendix and clarify that the length is to be measured in bytes#1850
Merged
richvdh merged 2 commits intomatrix-org:mainfrom Jun 12, 2024
Conversation
…larify that the length is to be measured in bytes Fixes: matrix-org#1826 Relates to: matrix-org#1001 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
johannes/size-limits
branch
from
68a8ff8 to
c35ba8f
Compare
richvdh
reviewed
Jun 11, 2024
|
|
||
| The length of a user ID, including the `@` sigil and the domain, MUST | ||
| NOT exceed 255 characters. | ||
| NOT exceed 255 bytes. |
Member
There was a problem hiding this comment.
For future reference: this restriction comes from the fact that a user ID must fit inside a state key (in the m.room.member event), and state keys have always been limited to 255 bytes (since 6a0595b)
Contributor
Author
There was a problem hiding this comment.
Do you think this and #1850 (comment) should also go into the spec?
Member
There was a problem hiding this comment.
no, that's fine. I just wanted to make a record so that when, in a few months, we come to look at this PR, we remember the thought process.
richvdh
reviewed
Jun 11, 2024
Comment on lines
+666
to
+667
| The length of a room ID, including the `!` sigil and the domain, MUST | ||
| NOT exceed 255 bytes. |
Member
There was a problem hiding this comment.
This was also previously specified in the C-S API, also going back to 6a0595b.
richvdh
reviewed
Jun 11, 2024
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1826
Relates to: #1001
Pull Request Checklist
Preview: https://pr1850--matrix-spec-previews.netlify.app