Skip to content

Add missing word header#1852

Merged
uhoreg merged 2 commits intomatrix-org:mainfrom
Johennes:johannes/missing-header
Jun 11, 2024
Merged

Add missing word header#1852
uhoreg merged 2 commits intomatrix-org:mainfrom
Johennes:johannes/missing-header

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 10, 2024

Pull Request Checklist

Preview: https://pr1852--matrix-spec-previews.netlify.app

Johennes added 2 commits June 10, 2024 10:19
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes marked this pull request as ready for review June 10, 2024 08:21
@Johennes Johennes requested a review from a team as a code owner June 10, 2024 08:21
@Johennes
Copy link
Contributor Author

On a related note, it seems like sending the retry_after_ms response field was downgraded from SHOULD to MAY in 1.10. I think for a proper deprecation it should have stayed SHOULD so that servers include it whenever they set the new header to support clients that haven't yet caught up with the spec. Given that this was already released, I suppose there's no point in changing it yet again though?

Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks

@uhoreg uhoreg merged commit 520b839 into matrix-org:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants