New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brand new frontpage #1554
Brand new frontpage #1554
Conversation
This is how the basic layout looks like on desktop Screen.Recording.2022-11-05.at.22.02.52.movand this is how it looks like on mobile Screen.Recording.2022-11-05.at.22.03.39.movObvious problems:
|
a1e3712
to
9e40df0
Compare
Left to do: use the mobile backgrounds on mobile (which will be handed by design on Monday 23). |
sass/_index.scss
Outdated
|
||
h2 { | ||
color: #fff; | ||
font-size: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably declare this relative to the parent, but not super important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure which part would be relative to the parent :) ?
Do you mean the font-size, in (r)em
instead of px
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean having font-sizes (except at the root) in %
or em
.
Left to do: