Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deeplinks with roomids for unjoined rooms into Element don't work #270

Closed
deepbluev7 opened this issue May 29, 2022 · 3 comments
Closed

Deeplinks with roomids for unjoined rooms into Element don't work #270

deepbluev7 opened this issue May 29, 2022 · 3 comments

Comments

@deepbluev7
Copy link
Contributor

Describe the bug
When following a matrix.to link, that uses a roomid and explicit vias, those vias are not passed on to Element, which makes the room unjoinable. Example: https://matrix.to/#/!xokVIsEhSxfAuiViWt:linuxdelta.com?via=linuxdelta.com&via=matrix.org&via=matrix.recursiv.com

To Reproduce
Steps to reproduce the behavior:

  1. Got to https://matrix.to/#/!xokVIsEhSxfAuiViWt:linuxdelta.com?via=linuxdelta.com&via=matrix.org&via=matrix.recursiv.com
  2. Hover over the Element button
  3. See that the url is element://vector/webapp/#/room%2F!xokVIsEhSxfAuiViWt%3Alinuxdelta.com
  4. Clicking this will fail to join

Expected behavior
matrix.to passes the vias to Element so that the room can actually be joined by clicking.
deepbluev7 added a commit to deepbluev7/matrix.to that referenced this issue May 29, 2022
@deepbluev7
Properly pass vias to Element clients
0ca4d66 
Should fix joining rooms by roomid via matrix.to.

fixes matrix-org#270

Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
@deepbluev7 deepbluev7 mentioned this issue May 29, 2022
Merged
@richvdh
Copy link
Member

richvdh commented Jun 6, 2022

dup #235 ?

@deepbluev7
Copy link
Contributor Author

Looks like it. Seems like I used the wrong search terms!

@t3chguy
Copy link
Member

t3chguy commented Jun 6, 2022

Duplicate of #235

@t3chguy t3chguy marked this as a duplicate of #235 Jun 6, 2022
@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richvdh @t3chguy @deepbluev7