New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting github attachments #52

Open
turt2live opened this Issue Dec 16, 2018 · 17 comments

Comments

Projects
None yet
3 participants
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Dec 16, 2018

for matrix.to?

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 16, 2018

Might make more sense inside the matrix-static codebase but connected to both domains

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 16, 2018

I think I'll do this in my little spare time

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 16, 2018

(in m-s so it can show room name etc etc, plus as matrix.to has no server component which is needed for the api)

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Dec 16, 2018

for matrix.to?

Yea, so that when people drop permalinks in github issues it magically works

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Dec 16, 2018

aaaah! that’d rock!

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 23, 2018

First draft, not very useful yet:
image

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 25, 2018

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Dec 25, 2018

bcc28bb8-4223-4849-b727-cd1259a51916

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 25, 2018

I just noticed I had the 💪 POWER to do that but opted not to :P

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 25, 2018

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 25, 2018

Turns out riot-dev isn't world viewable :P
https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org

matrix.to Remove

The Official Matrix HQ - please come chat here! | https://matrix.org/docs/spec | To support Matrix.org development: https://patreon.com/matrixdotorg | Looking for hosting? Check out https://upcloud.com/matrix!

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 25, 2018

also I think query args such as via will break the SUPER naive regex :P so I shall fix that

@t3chguy t3chguy closed this Dec 25, 2018

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Dec 25, 2018

Just for testing:

https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org/$15457111881337381EhwTO:matrix.org?via=matrix.org&via=half-shot.uk&via=disroot.org

matrix.to Remove

The Official Matrix HQ - please come chat here! | https://matrix.org/docs/spec | To support Matrix.org development: https://patreon.com/matrixdotorg | Looking for hosting? Check out https://upcloud.com/matrix!

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Dec 25, 2018

@t3chguy that should show the event

Edit: Looking great though!

@turt2live turt2live reopened this Dec 25, 2018

@t3chguy

This comment has been minimized.

Copy link
Collaborator

t3chguy commented Dec 26, 2018

Without joining the room to be able to use the context api or do loads of pagination showing events is currently not possible

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Dec 26, 2018

well that's no fun. We should fix that (or provide a guest-capable API to get the event).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment