Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Sydent doesn't delete 3PIDs from DB on unbind #192
According to https://github.com/matrix-org/sydent/blob/master/sydent/db/threepid_associations.py#L84-L87, when receiving an
…213) Fixes #192 On unbinding a threepid, Sydent would only set the Matrix ID (and some metadata) to NULL in the database, but keep the threepid address (email or phone number) around. This PR changes it so that rows are deletes instead of partially redacted, as well as adds a migration step to delete any rows with NULL Matrix ID fields from the local_threepid_associations table. Global associations were already deleted fully, so there is no reason to modify that database.