Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MSC2140 #180

Closed
wants to merge 43 commits into from

Conversation

@dbkr
Copy link
Member

commented Jul 29, 2019

  • Support Matrix OpenID for login
  • terms API to get and agree to terms

Includes #179 so tests can run

Currently pulls syditest in from the dev branch until it gets review

@jryans

This comment has been minimized.

Copy link
Member

commented on sydent/terms/terms.py in febfc2a Jul 24, 2019

You should also add a yaml package to setup.py. Maybe pyyaml>=3.11 to match Synapse?

@jryans

This comment has been minimized.

Copy link
Member

commented on sydent/http/httpserver.py in febfc2a Jul 25, 2019

The MSC says register is available at $prefix/account/register, so maybe something like:

        account = Resource()
        v2.putChild('account', account)
        account.putChild('register', self.sydent.servlets.registerServlet)
@dbkr dbkr requested a review from matrix-org/synapse-core Jul 29, 2019
Copy link
Member

left a comment

image

lolno. Sorry dave, please can we make this one more incremental.

dbkr added 3 commits Jul 31, 2019
syditest_subject/terms.yaml Outdated Show resolved Hide resolved
terms.sample.yaml Outdated Show resolved Hide resolved
dbkr and others added 10 commits Aug 8, 2019
Typos

Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
This allows `/account` to act as a complete check for "ready to use this
service", including auth token and terms state.
This makes the request idempotent. Also add a comment saying why
it's not throwing
Add more tweaks to terms branch
so we can use a different python/virtualenv to launch sydent to
the one that the tester uses
and use jsonwrap in hash details servlet
and switch to new exception-throwing get_args
@dbkr dbkr referenced this pull request Aug 21, 2019
dbkr and others added 5 commits Aug 21, 2019
Co-Authored-By: Erik Johnston <erik@matrix.org>
also import functools
@dbkr

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

split up into separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.