Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dockerfile for CI to run in #193

Open
wants to merge 3 commits into
base: master
from

Conversation

@anoadragon453
Copy link
Member

commented Aug 19, 2019

Adds a Dockerfile which sets up an environment for Sydent to run in.

Look, green tick!

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Aug 19, 2019

@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Aug 19, 2019

@erikjohnston
Copy link
Member

left a comment

Cool, I was more expecting us to just have an empty pipeline, but this works too. Any reason to not have the pipeline file in the repo? It feels odd to have the pipeline file external but all the CI scripts in repo

libxslt1-dev

# Install dependencies
RUN pip install https://github.com/matrix-org/sydent/tarball/master \

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Aug 20, 2019

Member

One usually builds from the checked out source, rather than just always fetching master.

docker/README.md Outdated Show resolved Hide resolved
Update docker/README.md
Co-Authored-By: Erik Johnston <erik@matrix.org>
libxslt1-dev

# Install dependencies
RUN pip install https://github.com/matrix-org/sydent/tarball/master \

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 10, 2019

Contributor

You probably want to run this last in the run script.

pip and setuptools can also break when you go down this path as I found while trying to build this out myself here

email templates wont translate over from a pip install.

Running as root is also incredibly dangerous as you can break out of the container

@neilisfragile neilisfragile moved this from In progress to Review in Homeserver Task Board Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.