Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception on bad args & catch in wrapper #198

Closed
wants to merge 5 commits into from

Conversation

@dbkr
Copy link
Member

commented Aug 22, 2019

Extends the jsonwrap wrapper so it catches errors and returns
approrpiate responses. Have get_args throw an suitable error that
the wrapper can catch.

Extends the jsonwrap wrapper so it catches errors and returns
approrpiate responses. Have get_args throw an suitable error that
the wrapper can catch.
@dbkr dbkr requested a review from matrix-org/synapse-core Aug 22, 2019
Copy link
Member

left a comment

I approve of this PR from the very depths of my soul.

sydent/http/servlets/__init__.py Show resolved Hide resolved
sydent/http/servlets/__init__.py Show resolved Hide resolved
sydent/http/servlets/__init__.py Outdated Show resolved Hide resolved
sydent/http/servlets/__init__.py Outdated Show resolved Hide resolved
dbkr and others added 3 commits Aug 22, 2019
Co-Authored-By: Erik Johnston <erik@matrix.org>
also import functools
@dbkr

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

Merging this on the cli because GH still isn't showing the latest commit so who knows what it would merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.