Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete threepid assocs on unbind and remove existing with migration #213

Merged
merged 4 commits into from Sep 23, 2019

Conversation

@anoadragon453
Copy link
Member

commented Sep 12, 2019

Fixes #192

On unbinding a threepid, Sydent would only set the Matrix ID (and some metadata) to NULL in the database, but keep the threepid address (email or phone number) around.

This PR changes it so that rows are deletes instead of partially redacted, as well as adds a migration step to delete any rows with NULL Matrix ID fields from the local_threepid_associations table.

Global associations were already deleted fully, so there is no reason to modify that database.

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Sep 12, 2019
@anoadragon453 anoadragon453 self-assigned this Sep 12, 2019
@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Sep 12, 2019
sydent/db/sqlitedb.py Outdated Show resolved Hide resolved
sydent/db/threepid_associations.py Show resolved Hide resolved
Homeserver Task Board automation moved this from In progress to Review Sep 13, 2019
@erikjohnston

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

A test for deleting a binding would be good 👍

anoadragon453 and others added 2 commits Sep 13, 2019
Co-Authored-By: Erik Johnston <erik@matrix.org>
@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

A test for deleting a binding would be good +1

We're hoping to add one in matrix-is-tester soon.

@dbkr

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

sydent master now has matrix-is-tester CI! (CI now failing until master gets merged into this branch)

@richvdh richvdh requested a review from erikjohnston Sep 23, 2019
@richvdh richvdh merged commit 04ac502 into master Sep 23, 2019
1 check passed
1 check passed
buildkite/sydent Build #150 passed (48 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Sep 23, 2019
richvdh added a commit that referenced this pull request Sep 23, 2019
@richvdh

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Updated the changelog in 0e01574 >:-|

richvdh added a commit that referenced this pull request Sep 25, 2019
…ration (#213)"

This reverts commits 04ac502 and 0e01574.
@richvdh

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

reverted by 969d57e due to #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.