Skip to content
Permalink
Browse files

bail out early in on_new_receipts if no pushers (#4706)

  • Loading branch information...
richvdh committed Feb 21, 2019
1 parent 6d65659 commit 0abb094f1ada9c4a78a11eb06b205c00db826860
Showing with 9 additions and 0 deletions.
  1. +1 −0 changelog.d/4706.misc
  2. +8 −0 synapse/push/pusherpool.py
@@ -0,0 +1 @@
Avoid some redundant work when processing read receipts
@@ -140,6 +140,10 @@ def remove_pushers_by_access_token(self, user_id, access_tokens):

@defer.inlineCallbacks
def on_new_notifications(self, min_stream_id, max_stream_id):
if not self.pushers:
# nothing to do here.
return

try:
users_affected = yield self.store.get_push_action_users_in_range(
min_stream_id, max_stream_id
@@ -155,6 +159,10 @@ def on_new_notifications(self, min_stream_id, max_stream_id):

@defer.inlineCallbacks
def on_new_receipts(self, min_stream_id, max_stream_id, affected_room_ids):
if not self.pushers:
# nothing to do here.
return

try:
# Need to subtract 1 from the minimum because the lower bound here
# is not inclusive

0 comments on commit 0abb094

Please sign in to comment.
You can’t perform that action at this time.