Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Declare support for Matrix v1.7 #15661

Closed

Description

@clokep

See the changelog (note that I stripped out spec clarifications).

Client-Server API

New Endpoints

Backwards Compatible Changes

Application Service API

New Endpoints

Backwards Compatible Changes


Depends on #15089.

Activity

  1. added
    A-Spec-Complianceplaces where synapse does not conform to the spec
    S-MajorMajor functionality / product severely impaired, no satisfactory workaround.
    T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.
    O-UncommonMost users are unlikely to come across this or unexpected workflow
    on May 23, 2023
  2. clokep commented on May 23, 2023

    @clokep
    MemberAuthor

    Addition of redirect downloads, as per matrix-org/matrix-spec-proposals#3860.

    Note that I think Synapse technically can declare 1.7 without actually doing anything for this, the spec for the /download and /thumbnail endpoints have a new allow_redirect query parameter:

    Indicates to the server that it may return a 307 or 308 redirect response that points at the relevant media content. When not explicitly set to true the server must return the media content itself.

    Those endpoints should already ignore unknown parameters, so should be compliant.

  3. tulir commented on May 24, 2023

    @tulir
    Member

    Note that I think Synapse technically can declare 1.7 without actually doing anything for this

    Synapse should implement following redirects when downloading media over federation, but I guess that might not be relevant for declaring support in the C-S API

  4. clokep commented on May 24, 2023

    @clokep
    MemberAuthor

    Note that I think Synapse technically can declare 1.7 without actually doing anything for this

    Synapse should implement following redirects when downloading media over federation, but I guess that might not be relevant for declaring support in the C-S API

    Yes, that's a good point! 👍 I always forget the S-S & C-S APIs are the same for media. 😢

  5. jplatte commented on Oct 9, 2023

    @jplatte
  6. clokep commented on Oct 9, 2023

    @clokep
    Author
  7. clokep commented on Oct 10, 2023

    @clokep
    Author
  8. clokep commented on Nov 28, 2023

    @clokep
    MemberAuthor

    Note that I think Synapse technically can declare 1.7 without actually doing anything for this

    Synapse should implement following redirects when downloading media over federation, but I guess that might not be relevant for declaring support in the C-S API

    Yes, that's a good point! 👍 I always forget the S-S & C-S APIs are the same for media. 😢

    #16701 should implement following the redirects on the S-S side.

  9. self-assigned this
    on Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-Spec-Complianceplaces where synapse does not conform to the specO-UncommonMost users are unlikely to come across this or unexpected workflowS-MajorMajor functionality / product severely impaired, no satisfactory workaround.T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions