This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Make sure that we close db connections opened during init #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should explicitly close any db connections we open, because failing to do so can block other transactions as per #3682. Let's also try to factor out some of the boilerplate by having server classes define their datastore class rather than duplicating the whole of `setup`.
|
Is it worth using |
AIUI that would mean subclasses would have to implement a |
Nope, we do it for the replication HTTP classes, e.g.: https://github.com/matrix-org/synapse/blob/master/synapse/replication/http/_base.py#L70 vs https://github.com/matrix-org/synapse/blob/master/synapse/replication/http/federation.py#L47 |
This gives clearer messages when someone gets it wrong
erikjohnston
approved these changes
Aug 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should explicitly close any db connections we open, because failing to do so
can block other transactions as per
#3682.
Let's also try to factor out some of the boilerplate by having server classes
define their datastore class rather than duplicating the whole of
setup.