Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cross-signing proposal #4110

Closed
uhoreg opened this issue Oct 29, 2018 · 7 comments

Comments

@uhoreg
Copy link
Member

@uhoreg uhoreg commented Oct 29, 2018

Implement server-side part of matrix-org/matrix-doc#1756. Part of vector-im/riot-meta#222.

  • manage master keys
  • store and retrieve local signatures
  • make sure signatures are properly filtered
  • notify users when new signatures need to be fetched
  • federate signatures
  • sytest everything
  • unit test everything
@uhoreg uhoreg self-assigned this Oct 29, 2018
@neilisfragile neilisfragile moved this from To Do to In Progress: Planned Project Work in Superceded by https://github.com/orgs/matrix-org/projects/8 Nov 1, 2018
@neilisfragile neilisfragile added the p1 label Nov 1, 2018
hawkowl added a commit that referenced this issue Nov 19, 2018
Features
--------

- Include flags to optionally add `m.login.terms` to the registration flow when consent tracking is enabled.
([\#4004](#4004), [\#4133](#4133),
[\#4142](#4142), [\#4184](#4184))
- Support for replacing rooms with new ones ([\#4091](#4091), [\#4099](#4099),
[\#4100](#4100), [\#4101](#4101))

Bugfixes
--------

- Fix exceptions when using the email mailer on Python 3. ([\#4095](#4095))
- Fix e2e key backup with more than 9 backup versions ([\#4113](#4113))
- Searches that request profile info now no longer fail with a 500. ([\#4122](#4122))
- fix return code of empty key backups ([\#4123](#4123))
- If the typing stream ID goes backwards (as on a worker when the master restarts), the worker's typing handler will no longer erroneously report rooms containing new
typing events. ([\#4127](#4127))
- Fix table lock of device_lists_remote_cache which could freeze the application ([\#4132](#4132))
- Fix exception when using state res v2 algorithm ([\#4135](#4135))
- Generating the user consent URI no longer fails on Python 3. ([\#4140](#4140),
[\#4163](#4163))
- Loading URL previews from the DB cache on Postgres will no longer cause Unicode type errors when responding to the request, and URL previews will no longer fail if
the remote server returns a Content-Type header with the chartype in quotes. ([\#4157](#4157))
- The hash_password script now works on Python 3. ([\#4161](#4161))
- Fix noop checks when updating device keys, reducing spurious device list update notifications. ([\#4164](#4164))

Deprecations and Removals
-------------------------

- The disused and un-specced identicon generator has been removed. ([\#4106](#4106))
- The obsolete and non-functional /pull federation endpoint has been removed. ([\#4118](#4118))
- The deprecated v1 key exchange endpoints have been removed. ([\#4119](#4119))
- Synapse will no longer fetch keys using the fallback deprecated v1 key exchange method and will now always use v2.
([\#4120](#4120))

Internal Changes
----------------

- Fix build of Docker image with docker-compose ([\#3778](#3778))
- Delete unreferenced state groups during history purge ([\#4006](#4006))
- The "Received rdata" log messages on workers is now logged at DEBUG, not INFO. ([\#4108](#4108))
- Reduce replication traffic for device lists ([\#4109](#4109))
- Fix `synapse_replication_tcp_protocol_*_commands` metric label to be full command name, rather than just the first character
([\#4110](#4110))
- Log some bits about room creation ([\#4121](#4121))
- Fix `tox` failure on old systems ([\#4124](#4124))
- Add STATE_V2_TEST room version ([\#4128](#4128))
- Clean up event accesses and tests ([\#4137](#4137))
- The default logging config will now set an explicit log file encoding of UTF-8. ([\#4138](#4138))
- Add helpers functions for getting prev and auth events of an event ([\#4139](#4139))
- Add some tests for the HTTP pusher. ([\#4149](#4149))
- add purge_history.sh and purge_remote_media.sh scripts to contrib/ ([\#4155](#4155))
- HTTP tests have been refactored to contain less boilerplate. ([\#4156](#4156))
- Drop incoming events from federation for unknown rooms ([\#4165](#4165))
@richvdh richvdh added the r0 P1 label Jan 7, 2019
@richvdh richvdh removed the r0 P1 label Jan 16, 2019
@uhoreg

This comment has been minimized.

Copy link
Member Author

@uhoreg uhoreg commented May 2, 2019

Main remaining work is cleaning up the code. We also need to decide whether to use the three-key system or the two-key system, but changing that should not take too long.

@lampholder lampholder mentioned this issue May 3, 2019
21 of 21 tasks complete
@Thatoo

This comment has been minimized.

Copy link

@Thatoo Thatoo commented May 22, 2019

Do you think cross-signing will be implemented in synapse 1.0?

@neilisfragile

This comment has been minimized.

Copy link
Contributor

@neilisfragile neilisfragile commented May 22, 2019

@Thatoo While cross signing is nearly ready, we are not expecting it to be there in time for 1.0.

@Thatoo

This comment has been minimized.

Copy link

@Thatoo Thatoo commented May 22, 2019

Good. Too bad for 1.0, it would have been awesome to be able to say "ok guys, matrix is mature for e2e with synapse 1.0".. :-)

@richvdh

This comment has been minimized.

Copy link
Member

@richvdh richvdh commented Nov 6, 2019

@uhoreg can we consider this closed if the synapse side is landed?

@richvdh

This comment has been minimized.

Copy link
Member

@richvdh richvdh commented Nov 6, 2019

@uhoreg

This comment has been minimized.

Copy link
Member Author

@uhoreg uhoreg commented Nov 6, 2019

Yes. Forgot there was an issue here.

@uhoreg uhoreg closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Superceded by https://github.com/orgs...
  
In Progress: Planned Project Work
5 participants
You can’t perform that action at this time.