Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Clarify docs for public_baseurl #4458

Merged
merged 2 commits into from Jan 24, 2019
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 24, 2019

This is leading to problems with people upgrading to clients that
support MSC1730 because people have this misconfigured, so try
to make the docs completely unambiguous.

NB. In a world without ACME support I probably would have also remove the 8448 from the example URL as this would never have worked, being a self-signed cert, but I guess now this is a plausible default, although it still feels like it's directing you towards it being the internal URL. wdyt?

This is leading to problems with people upgrading to clients that
support MSC1730 because people have this misconfigured, so try
to make the docs completely unambiguous.
@dbkr dbkr requested a review from a team January 24, 2019 10:57
@codecov-io
Copy link

Codecov Report

Merging #4458 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #4458      +/-   ##
==========================================
+ Coverage    74.79%   74.8%   +0.01%     
==========================================
  Files          336     336              
  Lines        33997   33997              
  Branches      5527    5527              
==========================================
+ Hits         25429   25433       +4     
+ Misses        7002    7001       -1     
+ Partials      1566    1563       -3

@neilisfragile neilisfragile merged commit 5c41b22 into develop Jan 24, 2019
@DMRobertson DMRobertson deleted the dbkr/public_baseurl_doc branch June 28, 2022 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants