Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-signed certificate notice is being displayed without the certificate being generated #4620

Closed
madonius opened this Issue Feb 11, 2019 · 7 comments

Comments

4 participants
@madonius
Copy link

commented Feb 11, 2019

Description

The notice about the self signed certificates is being displayed after the configuration file generation although this was removed in #4509
See:

" %r with corresponding SSL keys and self-signed"

Steps to reproduce

Generate the configuration file

Version information

  • Homeserver: local test environment
  • Version: v0.99.0

  • Install method: Docker

  • Platform: Docker
@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

I think this will be fixed by #4619

@richvdh richvdh closed this Feb 11, 2019

@madonius

This comment has been minimized.

Copy link
Author

commented Feb 11, 2019

This is not regarding the docker-specific templating. Rather we just used docker to generate a config file, we used

python -m synapse.app.homeserver \
    --server-name my.domain.name \
    --config-path homeserver.yaml \
    --generate-config \
    --report-stats=no

As described in https://github.com/matrix-org/synapse/blob/master/INSTALL.md

@madonius

This comment has been minimized.

Copy link
Author

commented Feb 11, 2019

cc @jcgruenhage

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

in that case, can you give more details about the repro steps and what symptoms you actually see?

@jcgruenhage

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

jcgruenhage  ~  docker run -it --rm --entrypoint /bin/sh docker.io/matrixdotorg/synapse
/ # python -m synapse.app.homeserver \
>     --server-name my.domain.name \
>     --config-path homeserver.yaml \
>     --generate-config \
>     --report-stats=no
A config file has been generated in 'homeserver.yaml' for server name 'my.domain.name' with corresponding SSL keys and self-signed certificates. Please review this file and customise it to your needs.
If this server name is incorrect, you will need to regenerate the SSL certificates

We just used docker to get a throwaway env with a synapse install quickly.
We ran a shell in the container, in which we used synapses good old --generate-config option to generate a config file.
As you can see, after the file was generated, we got a notice about a self signed certificate being created, which is not the case though.

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Right, the warning we are complaining about is this one:

 jcgruenhage  ~  docker run -it --rm --entrypoint /bin/sh docker.io/matrixdotorg/synapse
/ # python -m synapse.app.homeserver \
>     --server-name my.domain.name \
>     --config-path homeserver.yaml \
>     --generate-config \
>     --report-stats=no
A config file has been generated in 'homeserver.yaml' for server name 'my.domain.name' with corresponding SSL keys and self-signed certificates. Please review this file and customise it to your needs.
If this server name is incorrect, you will need to regenerate the SSL certificates

@richvdh richvdh reopened this Feb 12, 2019

richvdh added a commit that referenced this issue Feb 12, 2019

@neilisfragile

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

Looks fixed by #4625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.