Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you redact a tombstone you can't join the room any more. #5003

Open
ara4n opened this issue Apr 3, 2019 · 1 comment

Comments

4 participants
@ara4n
Copy link
Member

commented Apr 3, 2019

says linda

@neilisfragile neilisfragile added this to Holding Pen in Homeserver Task Board via automation Apr 5, 2019

@neilisfragile neilisfragile moved this from Holding Pen to To Do in Homeserver Task Board Apr 10, 2019

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

So from investigation I've found that redacting a tombstone in an upgraded room:

  • Still allows people who were in the old room to go back and look at it
  • In Riot web, removes the link in the "This room is no longer active" dialogue:

image

  • Makes it so users who aren't in the old room cannot view the new room (in Riot web). You click it in the room list and it highlights, but nothing else happens. Console logs:

image

  • If you invite the user to the old room they can join just fine, but they also have a broken upgrade message (no link to the new room)
  • Once the user is in the old room, they can switch to the new room just fine.

So we're looking at a few things here:

  • A bug in Riot web that allows the option to redact tombstone events
  • A bug in Synapse that allows you to redact tombstone events
  • A bug in Riot web that breaks it if the user joins a room with a predecessor room ID, but the referenced room does not have a tombstone event.

The link to the new room disappearing makes sense since that uses information stored in the tombstone.

@lampholder lampholder added the bug label Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.