Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split account_threepid_handler into a msisdn and email versions #5928

Closed
anoadragon453 opened this issue Aug 28, 2019 · 1 comment

Comments

@anoadragon453
Copy link
Member

commented Aug 28, 2019

We realized we could run into an issue where because Synapse can't support sending SMS yet, you may find yourself wanting to use Synapse to send password reset emails, but then can't support msisdn registration.

We need to split up account_threepid_handler into msisdn and email versions so that people can configure these things separately.

On the backend side, this will involve:

  • Updating UPGRADE.rst and other various changelog notes
  • Updating the requires_identity_server unstable /versions flag to have an email and msisdn version, so clients know what to do for each
  • Updating the account_threepid_handler config option and creating two, and updating all the checks to either be based off the msisdn or the email version
@anoadragon453 anoadragon453 self-assigned this Aug 28, 2019
@anoadragon453 anoadragon453 added this to Holding Pen in Homeserver Task Board via automation Aug 28, 2019
anoadragon453 added a commit that referenced this issue Sep 5, 2019
…erification (#5940)

Fixes: #5751
Fixes: #5928

#5835 allowed Synapse to send registration emails to the user. Now we need to accept them and have it succeed the `m.login.email.identity` registration flow step.

`account_threepid_handler` will also be switched from a `str` in the config file to a dictionary which contains entries for `msisdn` and `email`, each with their own `str`. This will let people use an external server to handle `msisdn` registration and password reset requests, while using Synapse for email-based things.

And the `password_servlet` hack that was introduced in https://github.com/matrix-org/synapse/pull/5377/files#diff-b8464485d36f6f87caee3f4d82524213R189 to distinguish a registration call from a password reset call will be removed.
@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2019

Done in #5940

Homeserver Task Board automation moved this from Holding Pen to Done Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.